Update creating-a-personal-access-token.md #867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The screenshot image for Step 6 'Give your token a descriptive name' is incorrect. This can cause confusion for developers who are new to GiHub, especially since all the other steps have correct screenshots. Issue #851 What's being changed: Line 29: Replaced the current incorrect screenshot's url with a url for [the correct screenshot.](https://res.cloudinary.com/ramizackaryshamir/image/upload/c_scale,w_270/v1603818860/pullrequest-meetyourcreator-ramizackaryshamir-lines_28-29_htggx1.png) (I'm resubmitting this pull request. This is my first time submitting a pull request, so I';m still making novice mistakes. Also, please let me know if there's any thing that I need to improve for future pull requests. Thanks so much!)
janiceilene
added
the
hacktoberfest-accepted
|
@MeetYourCreator Thank you so much for opening a PR! This is a great first pull request and we're excited that you've joined our community 💖 Updating this image is going to be a bit more complicated than it seems. This article covers multiple versions, so we need to track down when the change was made and possibly backport the image to older versions of GitHub Enterprise Server. I'm going to close this PR and use the information from here (and your super helpful issue!) to create an internal issue for a writer to look at. Thanks again for letting us know about this update! |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* update hierarchy for getting started revamp (github#823) * update hierarchy * changes for getting started launch doc pages (github#855) * update hierarchy * updates to first file * update launching doc pages * Apply suggestions from code review update text from suggestions Co-authored-by: Attila Tóth <[email protected]> * Update timescaledb/getting-started/launch-timescaledb/launch-timescaledb-docker.md Co-authored-by: Attila Tóth <[email protected]> * Edit new getting started launch content * some final little adjustments to clarify things Co-authored-by: Attila Tóth <[email protected]> Co-authored-by: Charis Lam <[email protected]> * Miranda/access database updates (github#867) * update first two files * add other page * Copy and style edit * some small adjustments Co-authored-by: Charis Lam <[email protected]> * Miranda/add data (github#917) * some edits * adding the data updates * small change * Apply suggestions from code review ryan's suggestions Co-authored-by: Ryan Booz <[email protected]> * some updates * Update timescaledb/getting-started/add-data.md * more changes * Apply suggestions from code review add updates Co-authored-by: Charis <[email protected]> * Apply suggestions from code review more edits * update some line lengths * Update timescaledb/getting-started/add-data.md updates Co-authored-by: Charis <[email protected]> Co-authored-by: Ryan Booz <[email protected]> Co-authored-by: Charis <[email protected]> * Miranda/create hypertable (github#913) * some updates * updates to the hypertable chunks page. * remove section and change around a few things * Apply suggestions from code review updates Co-authored-by: Ryan Booz <[email protected]> * Apply suggestions from code review changes Co-authored-by: Charis <[email protected]> * Apply suggestions from code review * Apply suggestions from code review more edits * Update timescaledb/getting-started/create-hypertable.md edits * fix line lengths Co-authored-by: Ryan Booz <[email protected]> Co-authored-by: Charis <[email protected]> * miranda/query-your-data updates to the getting started guide (github#936) * add changes * updates * Apply suggestions from code review add changes Co-authored-by: Lana Brindley <[email protected]> * Apply suggestions from code review updates Co-authored-by: Charis <[email protected]> * Apply suggestions from code review final edits * Update timescaledb/getting-started/query-data.md more stuff * Update timescaledb/getting-started/query-data.md last one * Update timescaledb/getting-started/query-data.md little fix * Apply suggestions from code review two more little changes Co-authored-by: Lana Brindley <[email protected]> Co-authored-by: Charis <[email protected]> * Miranda/continuous agg getting started (github#950) * changes * first pass of the continuous aggregates * fix link issue * Apply suggestions from code review updates Co-authored-by: Charis <[email protected]> * Apply suggestions from code review more changes Co-authored-by: Charis <[email protected]> * some more updates * updates Co-authored-by: Charis <[email protected]> * retention updates (github#958) * retention updates * Apply suggestions from code review some updates Co-authored-by: Rajakavitha Kodhandapani <[email protected]> * last changes Co-authored-by: Rajakavitha Kodhandapani <[email protected]> * Miranda/compression-getting-started-update (github#962) * more updates * Apply suggestions from code review updates Co-authored-by: Lana Brindley <[email protected]> Co-authored-by: Lana Brindley <[email protected]> * updates to include extra docker step (github#978) * updates to include extra docker step * Apply suggestions from code review updates Co-authored-by: Charis <[email protected]> Co-authored-by: Lana Brindley <[email protected]> * Apply suggestions from code review test bullet * Update timescaledb/getting-started/add-data.md test bullet again * updates I made Co-authored-by: Charis <[email protected]> Co-authored-by: Lana Brindley <[email protected]> * Final changes for getting started guide (github#996) * had to make a change * remove install and connecting pages * last edits * Apply suggestions from code review Add suggested changes Co-authored-by: Ryan Booz <[email protected]> * more final edits * found small issue * small update * Apply suggestions from code review fix weird table * get rid of paragraph symbols in table * Update timescaledb/getting-started/add-data.md Adding the correct link for the data file. * Update page-index.js Not sure how I've missed this outline previously, but we want people to save space with compression on raw data before we drop old data. This probably came from earlier discussions that a lot of stock/crypto folks seem to want to drop raw data ASAP, so totally understandable. With this order (and assuming data we provide is ~1 month of data), users get raw data in -> continuous aggregates for rollup and faster query -> compress data that's older than 2 weeks -> drop raw data that's older than 3. This feels like a better overall flow. * Update timescaledb/getting-started/add-data.md * Update timescaledb/getting-started/create-cagg/create-cagg-basics.md Co-authored-by: Lana Brindley <[email protected]> * Update timescaledb/getting-started/compress-data.md * Update timescaledb/getting-started/compress-data.md * Update timescaledb/getting-started/query-data.md * Update timescaledb/getting-started/add-data.md * Update timescaledb/getting-started/query-data.md * Update timescaledb/getting-started/query-data.md * fixed the steps in the procedure * Fix indentation * Apply suggestions from code review Still more suggestions to review, but need to move on for a bit. Will finish review in a couple of hours. Co-authored-by: Charis <[email protected]> Co-authored-by: Lana Brindley <[email protected]> Co-authored-by: Rajakavitha Kodhandapani <[email protected]> * Apply suggestions from code review A few more suggestions to review and think about. Should finish in the morning. Co-authored-by: Rajakavitha Kodhandapani <[email protected]> Co-authored-by: Attila Tóth <[email protected]> Co-authored-by: Charis <[email protected]> Co-authored-by: Lana Brindley <[email protected]> * Edits for wording, flow, and adding basic procedure sections for alignment with other docs. * Minor fixes to the query page * Apply suggestions from code review Co-authored-by: Charis <[email protected]> Co-authored-by: Attila Tóth <[email protected]> Co-authored-by: Charis Lam <[email protected]> Co-authored-by: Jacob Prall <[email protected]> Co-authored-by: Ryan Booz <[email protected]> Co-authored-by: Lana Brindley <[email protected]> Co-authored-by: Rajakavitha Kodhandapani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The screenshot image for Step 6 'Give your token a descriptive name' is incorrect. This can cause confusion for developers who are new to GiHub, especially since all the other steps have correct screenshots. Issue #851
What's being changed:
Line 29: Replaced the current incorrect screenshot's url with a url for the correct screenshot.
(I'm resubmitting this pull request. This is my first time submitting a pull request, so I'm still making novice mistakes. Also, please let me know if there's any thing that I need to improve for future pull requests. Thanks so much!)
Check off the following: