Skip to content

Fix VariantInternal initialization and setting of object #43992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix VariantInternal initialization and setting of object #43992

merged 1 commit into from
Nov 30, 2020

Conversation

@vnen
Copy link
Member

@vnen vnen commented Nov 30, 2020 •
edited
Loading

  • Initialize Object pointer to nullptr so it's not used by mistake.
  • When setting an Object check if it's a reference so refcounting works as intended.

Fix #43941
Fix #43851

@vnen
Fix VariantInternal initialization and setting of object
029fd88 
- Initialize Object pointer to nullptr so it's not used by mistake.
- When setting an Object check if it's a reference so refcounting works
  as intended.
@vnen vnen added this to the 4.0 milestone Nov 30, 2020
@vnen vnen mentioned this pull request Nov 30, 2020
Closed
@akien-mga akien-mga requested a review from reduz November 30, 2020 18:10
@akien-mga akien-mga merged commit 04bef80 into godotengine:master Nov 30, 2020
@akien-mga
Copy link
Member

akien-mga commented Nov 30, 2020

Thanks!

@jordo
Copy link
Contributor

jordo commented Nov 30, 2020

awesome, thx so much as well!

@vnen vnen deleted the variant-internal-object-set branch November 30, 2020 20:24
@briansemrau briansemrau mentioned this pull request Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees

No one assigned

Labels

bug topic:gdscript

Projects

None yet

Milestone

4.0

3 participants

@vnen @akien-mga @jordo