[GDScript 2.0] Don't double-reference Refs returned from function #53135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 28, 2021
briansemrau
force-pushed
the
fix-ref-leak
branch
from
7216543 to
b11cd0d
Compare
briansemrau
commented
Sep 28, 2021
briansemrau
force-pushed
the
fix-ref-leak
branch
from
b11cd0d to
0647008
Compare
briansemrau
force-pushed
the
fix-ref-leak
branch
from
0647008 to
6141ce2
Compare
Member
|
The current version looks pretty clean, kudos. I'll let @vnen review/confirm that it's the best approach. |
Member
|
Poke @vnen. |
Member
|
I checked #52699 and with my original code some instances are still leaked with the typed line. So it fixes only half of the issue. |
vnen
approved these changes
Jun 24, 2022
Member
vnen
left a comment
vnen
left a comment
There was a problem hiding this comment.
It looks okay to me. I guess this a bit tricky to wrap the head around since there's a lot going on under the hood.
I wonder if we should restore the set_object() function that I removed in #43992, though having one just for updating the ID should be good enough.
Maybe a comment here about the reference counting would be handy so it isn't wrongly changed in the future.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDScript 2.0 opcode
OPCODE_CALL_PTRCALL_OBJECTwill double-reference returnedRefs. This results in a memory leak.This change fixes that issue while still keeping the fixes of #43992
Fixes #53093
Fixes #52699
(both issues are the same underlying bug)
@vnen Requesting review to make sure there are no regressions to #43941 or #43851