Skip to content

Conversation

alex-pakalniskis
Copy link
Contributor

Removes references to Cobb-Douglas, rebate pools, and legacy allocation states. Tagging @tmigone for visibility.

Thanks 😄

@alex-pakalniskis alex-pakalniskis requested a review from a team as a code owner August 1, 2023 22:26
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this is good from a "removing prior references" standpoint, I think maybe there could be a short explanation within the docs themselves (vs. always linking to the GIP) to explain why there is a rebate function at all, and in laymans terms how the exponential rebate function works.

---

Indexers are node operators in The Graph Network that stake Graph Tokens (GRT) in order to provide indexing and query processing services. Indexers earn query fees and indexing rewards for their services. They also earn from a Rebate Pool that is shared with all network contributors proportional to their work, following the Cobb-Douglas Rebate Function.
Indexers are node operators in The Graph Network that stake Graph Tokens (GRT) in order to provide indexing and query processing services. Indexers earn query fees and indexing rewards for their services. They also earn query fees that are rebated according to an exponential rebate function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth providing a bit more of a legible explanation of what the rebate function is for (essentially ensuring that indexers have sufficient stake allocated when claiming a given amount of query fees)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. To be explicit, after "to an exponential rebate function.", you could add:

This aim of using this rebate function is to ensure indexers achieve the best outcome by faithfully serving queries. This works by incentivizing Indexers to allocate a large amount of stake (which can be slashed for erring when serving a query) relative to the amount of query fees they may collect.

Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with Adam's point on adding a brief explainer on the new mechanism, maybe in the section where we link to the GIP we could add one sentence or two kind of a TL;DR for the GIP. @howardheaton might be able to help?

@howardheaton
Copy link

@tmigone, I agree. It's a bit long, but how about this for a tl;dr?

The exponential rebates function is proposed as a way to ensure indexers achieve the best outcome by faithfully serving queries. It works by incentivizing Indexers to allocate a large amount of stake (which can be slashed for erring when serving a query) relative to the amount of query fees they may collect.

@alex-pakalniskis alex-pakalniskis merged commit 12e8494 into graphprotocol:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants