Skip to content

Conversation

alex-pakalniskis
Copy link
Contributor

#454 (comment)

@howard-the-graph please confirm if this looks good to go.

@alex-pakalniskis alex-pakalniskis requested a review from a team as a code owner August 10, 2023 17:51
Copy link

@howard-the-graph howard-the-graph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend a minor revision to be more concise and avoid vague phrases about relative amounts:

The exponential rebate function is proposed as a way to ensure indexers achieve the best outcome by faithfully serving queries. It works by incentivizing Indexers to allocate stake, which can be slashed for erring when serving a query.

@howard-the-graph
Copy link

Separately, the phrase "by the gateway and" should be removed from the first sentence of the paragraph.

@alex-pakalniskis
Copy link
Contributor Author

alex-pakalniskis commented Sep 12, 2023

@benface I'm seeing that "All checks have failed" AND "This branch has no conflicts with the base branch"

Do you have any recommendations for resolving this? (I don't want to break the docs 😅 ). Can I proceed safely with "Squash and Merge"?

Thanks

@benface
Copy link
Contributor

benface commented Sep 12, 2023

@alex-pakalniskis – Uhhh yeah that's weird:

CleanShot 2023-09-12 at 11 20 34@2x

I can't imagine the change in this PR introducing any sort of failure, so I would just ignore it yes.

@benface
Copy link
Contributor

benface commented Sep 12, 2023

cc @saihaj @B2o5T ☝️

@alex-pakalniskis alex-pakalniskis merged commit 9f70131 into graphprotocol:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants