Skip to content

indexer agent & cli - max lifetime options #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

indexer agent & cli - max lifetime options #343

merged 1 commit into from
Feb 22, 2022

Conversation

@hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Jan 4, 2022 •
edited
Loading

Purpose

Currently, agent uses maximum allocations provided by the network, which is 28 epoches on the mainnet. Some indexers might want the agent to renew the allocations more frequently

Updates

  • Allow indexer to configure deployment-based lifetimes. Use indexer-cli and set with an integer using allocationLifetime
  • Indexing rules table shows allocationMaxLifetime for each allocation
  • The order of importance is id-specific allocationLifetime, global allocationLifetime, and then network max epoch. Agent allows you to set lifetimes higher than network maximum so be careful with it

Future considerations

  • this can allow indexer to compound the rewards more often and automatic, but closeAndAllocate doesn't account for rewards as the transaction are instant

@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch from 67296c9 to b142632 Compare January 12, 2022 19:58
@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch from b142632 to 0638bd3 Compare January 27, 2022 00:18
@hopeyen hopeyen changed the title [WIP] indexer agent & cli - max lifetime config indexer agent & cli - max lifetime options Jan 27, 2022
@hopeyen hopeyen requested a review from fordN January 27, 2022 00:34
@hopeyen hopeyen marked this pull request as ready for review January 27, 2022 00:36
hopeyen
hopeyen commented Jan 27, 2022
View reviewed changes
@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch 6 times, most recently from c325939 to aa21d9b Compare February 2, 2022 17:06
fordN
fordN requested changes Feb 15, 2022
View reviewed changes
@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch 3 times, most recently from fb8271a to a467d09 Compare February 17, 2022 00:55
hopeyen
hopeyen commented Feb 17, 2022
View reviewed changes
@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch from a467d09 to 5c4203e Compare February 18, 2022 01:27
@hopeyen hopeyen requested review from fordN and removed request for fordN February 18, 2022 01:31
@hopeyen hopeyen force-pushed the hope/max_lifetime_config branch from 5c4203e to 9e8009f Compare February 18, 2022 01:36
@hopeyen hopeyen requested a review from fordN February 18, 2022 16:18
@fordN fordN force-pushed the hope/max_lifetime_config branch from 9e8009f to 6bd47ac Compare February 22, 2022 21:59
@fordN fordN force-pushed the hope/max_lifetime_config branch from 6bd47ac to b470d45 Compare February 22, 2022 22:03
fordN
fordN approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fordN fordN merged commit ba14ae7 into main Feb 22, 2022
@fordN fordN deleted the hope/max_lifetime_config branch February 22, 2022 22:20
@hopeyen hopeyen mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fordN fordN fordN approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hopeyen @fordN