Skip to content

Showcase - Utilities pages alignments #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025
Merged

Showcase - Utilities pages alignments #3014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
267fc41
HDS-5076 Fix: Add model to `DismissButton` showcase route
dchyun Jul 15, 2025
7622e21
Fix: `DisclosurePrimitve` controller - update `toggleState` function
dchyun Jul 15, 2025
b200a62
Chore: Add comment to JIRA ticket in `PopoverPrimitive` showcase
dchyun Jul 15, 2025
17cc7b9
Fix: Update `toggleState` function to make `state` required
dchyun Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion showcase/app/controllers/page-utilities/disclosure-primitive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class PageUtilitiesDisclosurePrimitiveController extends Controll
this.isOpen = true;
} else if (state === 'close') {
this.isOpen = false;
} else {
} else if (state === 'toggle') {
this.isOpen = !this.isOpen;
}
}
Expand Down
5 changes: 5 additions & 0 deletions showcase/app/routes/page-utilities/dismiss-button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';

export type PageUtilitiesDismissButtonModel =
ModelFrom<PageUtilitiesDismissButtonRoute>;

export default class PageUtilitiesDismissButtonRoute extends Route {
model() {
// these are used only for presentation purpose in the showcase
Expand Down
2 changes: 1 addition & 1 deletion showcase/app/templates/page-utilities/disclosure-primitive.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
<SF.Item @grow={{true}}>
<button type="button" {{on "click" (fn this.toggleState "open")}}>Open</button>
<button type="button" {{on "click" (fn this.toggleState "close")}}>Close</button>
<button type="button" {{on "click" (fn this.toggleState "")}}>Toggle</button>
<button type="button" {{on "click" (fn this.toggleState "toggle")}}>Toggle</button>
<div class="shw-utility-disclosure-primitive-container">
<Hds::DisclosurePrimitive @isOpen={{this.isOpen}} @onClickToggle={{this.onClickToggle}}>
<:toggle as |t|>
Expand Down
1 change: 1 addition & 0 deletions showcase/app/templates/page-utilities/popover-primitive.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
class="shw-utilities-popover-primitive-fake-toggle"
{{PP.setupPrimitiveToggle}}
>Toggle</button>
{{! TODO Set anchoredPositionOptions to optional https://hashicorp.atlassian.net/browse/HDS-5148 }}
<div
class="shw-utilities-popover-primitive-fake-popover"
{{PP.setupPrimitivePopover anchoredPositionOptions=(hash)}}
Expand Down