Skip to content

Conversation

lbourdois
Copy link
Contributor

Hi @lewtun,

The notebooks of the course have been adapted in French as mentioned in huggingface/course#309.
They are all running fine on Google Colab except for the 7/5 in Tensorflow that Matt has to fix (cf. the exchanges on Slack).
I'll switch from "draft" to "final" mode when Matt will have corrected the missing notebook.
I only uppressed the cell outputs compared to the english version to make it less heavy.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@lbourdois lbourdois marked this pull request as draft October 12, 2022 16:52
@lewtun
Copy link
Member

lewtun commented Oct 14, 2022

Thanks a lot @lbourdois for converting all the notebooks 🔥 !! Gently pinging @Rocketknight1 for a fix of the TensorFlow section

@lbourdois
Copy link
Contributor Author

The missing notebook is working fine now thanks to huggingface/course#344.
The PR also contains TF changes of files 7/2, 7/3, 7/4, 7/6 and 7/7, so I have to propagate them and check that nothing has been broken. I plan to do this by Friday at the latest.

@lbourdois lbourdois marked this pull request as ready for review October 25, 2022 15:37
@lbourdois
Copy link
Contributor Author

@lewtun Everything should be ok now :)

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the final changes @lbourdois - amazing work on converting these notebooks to French 🥐 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants