fix(dvclive): pass fake dataset to avoid exception in trainer init #34455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
force-pushed
the
fix-dvclive-integration
branch
2 times, most recently
from
56fa988 to
303873c
Compare
shcheklein
changed the title
shcheklein
force-pushed
the
fix-dvclive-integration
branch
from
303873c to
8e9d512
Compare
Member
|
cc @SunMarc @jackyjinjing for the original PR! |
SunMarc
approved these changes
Nov 5, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
shcheklein
force-pushed
the
fix-dvclive-integration
branch
from
8e9d512 to
b16bf54
Compare
Contributor
Author
|
@SunMarc done, rebased |
CezaPasc
added a commit
to CezaPasc/transformers
that referenced
this pull request
Nov 13, 2024
5 tasks
4 tasks
LysandreJik
pushed a commit
that referenced
this pull request
Nov 15, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…uggingface#34455) fix(dvclive): pass fake dataset to avoid exception in trainer
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these failing tests https://github.com/iterative/dvclive/actions/runs/11545815176/job/32134865977?pr=846 downstream.
The cause is this change: #33743 which made
trainerctr a bit more strict.I see that
WandbCallbackis also using the same technique (initializing fake trainer). @parambharat could you check if we need to add a similar fix there.