Skip to content

Conversation

@CezaPasc
Copy link
Contributor

What does this PR do?

This PR passes a fake evaluation dataset for the initialisation of the fake_trainer of WandB.
This is necessary, since the init of the Trainer checks if an eval_strategy is set and raises an error if the eval_dataset is missing.
This issue is documented in #34701.
The fix here is similar to the one in #34455.

Fixes # (issue)

  • Pass ["fake"] as eval_dataset during initialisation of fake_trainer for saving purposes of WandB.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@LysandreJik
Copy link
Member

Hello @CezaPasc, I believe this should have been fixed with #34455

@LysandreJik
Copy link
Member

Ah, my bad, I see where this one is different. There are a few files which are changed which shouldn't be; do you mind keeping the diff only to the fix here? Thank you!

@CezaPasc CezaPasc force-pushed the fix-fake-trainer-init branch from 4113d93 to 657d544 Compare November 15, 2024 10:52
@CezaPasc
Copy link
Contributor Author

@LysandreJik
It seems like I got the other diffs from rebasing with the upstream.
I reverted them so that the diff should now only be about the changes in this PR again.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@LysandreJik LysandreJik merged commit 7b3d615 into huggingface:main Nov 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants