chore: suggested-log-tab-changes #935
Conversation
| public readonly traceDetails$: Observable<TraceDetails>; | ||
|
|
||
| public constructor( | ||
| private readonly subscriptionLifecycle: SubscriptionLifecycle, |
There was a problem hiding this comment.
this was one problem - subscription lifecycle should be provided in the component whenever used, since it's meant to be be tied to the component lifecycle. With out an explicit provider here, we're not cleaning this up which is why it gets undefined in it when we navigate away.
|
|
||
| public onDashboardReady(dashboard: Dashboard): void { | ||
| this.subscriptionLifecycle.add( | ||
| this.traceDetails$.subscribe(traceDetails => { |
There was a problem hiding this comment.
this is just a really ugly pattern that we have a better alternative for now, although we don't use it enough
|
|
||
| export const traceDetailDashboard: DashboardDefaultConfiguration = { | ||
| location: 'TRACE_DETAIL', |
There was a problem hiding this comment.
this page was moved but the dashboard wasn't - fixed
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <ht-application-aware-dashboard |
There was a problem hiding this comment.
this is its own page with a url, so should be navigable dashboard
Codecov Report
@@ Coverage Diff @@
## log-tab #935 +/- ##
===========================================
+ Coverage 85.13% 85.21% +0.07%
===========================================
Files 811 812 +1
Lines 16715 16703 -12
Branches 2099 2099
===========================================
+ Hits 14230 14233 +3
+ Misses 2453 2438 -15
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
2 participants
No description provided.