chore: suggested-log-tab-changes #935
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,38 @@ | ||
| import { ChangeDetectionStrategy, Component } from '@angular/core'; | ||
| import { Observable } from 'rxjs'; | ||
| import { map } from 'rxjs/operators'; | ||
| import { TraceDetailService } from './../trace-detail.service'; | ||
| import { traceSequenceDashboard } from './trace-sequence.dashboard'; | ||
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <ht-navigable-dashboard | ||
| *htLoadAsync="this.traceVariables$ as traceVariables" | ||
| class="scrollable-container" | ||
| [padding]="0" | ||
| [variables]="traceVariables" | ||
| navLocation="${traceSequenceDashboard.location}" | ||
| > | ||
| </ht-navigable-dashboard> | ||
| ` | ||
| }) | ||
| export class TraceSequenceComponent { | ||
| public readonly traceVariables$: Observable<TraceDetailVariables>; | ||
|
|
||
|
There was a problem hiding this comment. this is just a really ugly pattern that we have a better alternative for now, although we don't use it enough |
||
| public constructor(private readonly traceDetailService: TraceDetailService) { | ||
| this.traceVariables$ = this.traceDetailService.fetchTraceDetails().pipe( | ||
| map(details => ({ | ||
| traceId: details.id, | ||
| startTime: details.startTime, | ||
| spanId: details.entrySpanId | ||
| })) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| interface TraceDetailVariables { | ||
| traceId: string; | ||
| startTime?: string | number; | ||
| spanId?: string; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,35 @@ | ||
| import { ChangeDetectionStrategy, Component } from '@angular/core'; | ||
| import { Observable } from 'rxjs'; | ||
| import { map } from 'rxjs/operators'; | ||
| import { ApiTraceDetailService } from './../api-trace-detail.service'; | ||
| import { apiTraceSequenceDashboard } from './api-trace-sequence.dashboard'; | ||
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
|
There was a problem hiding this comment. this is its own page with a url, so should be navigable dashboard |
||
| <ht-navigable-dashboard | ||
| *htLoadAsync="this.traceVariables$ as traceVariables" | ||
| navLocation="${apiTraceSequenceDashboard.location}" | ||
| [padding]="0" | ||
| [variables]="traceVariables" | ||
| > | ||
| </ht-navigable-dashboard> | ||
| ` | ||
| }) | ||
| export class ApiTraceSequenceComponent { | ||
| public readonly traceVariables$: Observable<ApiTraceDetailVariables>; | ||
|
|
||
| public constructor(private readonly apiTraceDetailService: ApiTraceDetailService) { | ||
| this.traceVariables$ = this.apiTraceDetailService.fetchTraceDetails().pipe( | ||
| map(details => ({ | ||
| traceId: details.id, | ||
| startTime: details.startTime | ||
| })) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| interface ApiTraceDetailVariables { | ||
| traceId: string; | ||
| startTime?: string | number; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { DashboardDefaultConfiguration } from '@hypertrace/distributed-tracing'; | ||
|
|
||
| export const apiTraceSequenceDashboard: DashboardDefaultConfiguration = { | ||
| location: 'API_TRACE_SEQUENCE', | ||
| json: { | ||
| type: 'container-widget', | ||
| layout: { | ||
| type: 'auto-container-layout', | ||
| 'enable-style': false | ||
| }, | ||
| children: [ | ||
| { | ||
| type: 'waterfall-widget', | ||
| title: 'Sequence Diagram', | ||
| data: { | ||
| type: 'api-trace-waterfall-data-source', | ||
| // tslint:disable-next-line: no-invalid-template-strings | ||
| 'trace-id': '${traceId}', | ||
| // tslint:disable-next-line: no-invalid-template-strings | ||
| 'start-time': '${startTime}' | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was one problem - subscription lifecycle should be provided in the component whenever used, since it's meant to be be tied to the component lifecycle. With out an explicit provider here, we're not cleaning this up which is why it gets undefined in it when we navigate away.