Skip to content

Conversation

@pfilipko1
Copy link
Contributor

@pfilipko1 pfilipko1 commented Jul 19, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

@pfilipko1 pfilipko1 changed the title WIP: inital commit WIP: dotnet profiler inital commit Jul 19, 2022
@pfilipko1 pfilipko1 changed the title WIP: dotnet profiler inital commit dotnet profiler inital commit Aug 1, 2022
@Jongy Jongy self-requested a review August 1, 2022 19:06
@pfilipko1 pfilipko1 changed the title dotnet profiler inital commit dotnet profiler addtition Aug 3, 2022
@pfilipko1 pfilipko1 requested a review from Jongy August 31, 2022 08:09
@Jongy
Copy link
Contributor

Jongy commented Sep 5, 2022

@pfilipko1 I ran gProfiler exe from the last commit (bdba8e0) and I get this:

[2022-09-05 18:48:28,249] ERROR: gprofiler.profilers.profiler_base: DotnetProfiler: failed to profile process 1032935 (dotnet)
Traceback (most recent call last):
  File "gprofiler/profilers/profiler_base.py", line 119, in _wait_for_profiles
    result = future.result()
  File "concurrent/futures/_base.py", line 425, in result
  File "concurrent/futures/_base.py", line 384, in __get_result
  File "concurrent/futures/thread.py", line 56, in run
  File "gprofiler/profilers/dotnet.py", line 114, in _profile_process
    kill_signal=signal.SIGKILL,
  File "gprofiler/utils/__init__.py", line 265, in run_process
    raise CalledProcessError(retcode, process.args, output=stdout, stderr=stderr)
gprofiler.exceptions.CalledProcessError: Command '['/tmp/_MEIAyTTB6/gprofiler/resources/dotnet/tools/dotnet-trace', 'collect', '--format', 'speedscope', '--process-id', '1', '--profile', 'cpu-sampling', '--duration', '0:00:05', '--output', '/tmp/gprofiler_tmp/tmp1o0qgnex/dotnet-trace-UYwYIgaCfZnCUZNL-1032935']' returned non-zero exit status 131. 
stdout: b''
stderr: b'You must install .NET to run this application.\n\nApp: /tmp/_MEIAyTTB6/gprofiler/resources/dotnet/tools/dotnet-trace\nArchitecture: x64\nApp host version: 6.0.7\n.NET location: Not found\n\nLearn about runtime installation:\nhttps://aka.ms/dotnet/app-launch-failed\n\nDownload the .NET runtime:\nhttps://aka.ms/dotnet-core-applaunch?missing_runtime=true&arch=x64&rid=ubuntu.22.04-x64&apphost_version=6.0.7\n'

@Jongy
Copy link
Contributor

Jongy commented Sep 6, 2022

Size changes:
Before

image
gprofiler                      latest             5f687700d697   6 days ago       381MB
bin
 => => copying files 82.17MB                                                                                                                                                                          0.1s

After

image
gprofiler                      latest             169d31f652e1   40 seconds ago   460MB
bin
 => => copying files 100.58MB                                                                                                                                                                         0.2s

@Jongy
Copy link
Contributor

Jongy commented Sep 6, 2022

You can add ".NET" to https://github.com/Granulate/gprofiler#architecture-support. (only for x86_64). And mark as experimental

Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will run some tests on it and then merge.

@Jongy Jongy merged commit e59e449 into intel:master Sep 6, 2022
@Jongy Jongy mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants