Skip to content

Add PoC speedscope -> collapsed converter #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2022
Merged

Add PoC speedscope -> collapsed converter #422

merged 2 commits into from
Aug 16, 2022

Conversation

@Jongy
Copy link
Contributor

@Jongy Jongy commented Jul 26, 2022

PoC for #412

@Jongy Jongy requested a review from michelhe August 15, 2022 18:42
@Jongy Jongy marked this pull request as ready for review August 15, 2022 18:43
@Jongy Jongy force-pushed the speedscope-converter branch from b68ce9b to 5c5f07a Compare August 15, 2022 18:43
@Jongy
Copy link
Contributor Author

Jongy commented Aug 15, 2022

Should pass now. @michelhe let's merge this - it's just a utils file that is unused in this PR, I have written it for #412

michelhe
michelhe approved these changes Aug 16, 2022
View reviewed changes
Copy link

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I would prefer to only merge such things along with a unittest, but as long as nothing uses it, whatever.

The code is slightly unreadable due to the deep nested for-loops, I consider we should split it up but up to you

@Jongy
Copy link
Contributor Author

Jongy commented Aug 16, 2022

We'll add tests once this is actually used

@Jongy
Copy link
Contributor Author

Jongy commented Aug 16, 2022

Not doing any refactor now

@Jongy Jongy merged commit 1b57f89 into master Aug 16, 2022
@Jongy Jongy deleted the speedscope-converter branch August 16, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michelhe michelhe michelhe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jongy @michelhe