Skip to content

Conversation

@tengqm
Copy link
Contributor

@tengqm tengqm commented Feb 28, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for k8s-v1-25 ready!

Name Link
🔨 Latest commit a93ae8f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-v1-25/deploys/63fd49ea5a04710008fe7ccc
😎 Deploy Preview https://deploy-preview-39719--k8s-v1-25.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim February 28, 2023 00:09
@kbhawkey
Copy link
Contributor

OK, the branch has changed 👀

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@jihoon-seo
Copy link
Member

For the record:
the "Example" button is now working in the preview.

(cf. the one in prod website is not working for now.)

@jihoon-seo
Copy link
Member

@tengqm This PR has 2 commits, where the second one ('Backport cve-feed shortcode') seems not related to this PR or the first one.
Is the inclusion of second commit to this PR intentional or unintended?

@tengqm
Copy link
Contributor Author

tengqm commented Feb 28, 2023

@tengqm This PR has 2 commits, where the second one ('Backport cve-feed shortcode') seems not related to this PR or the first one. Is the inclusion of second commit to this PR intentional or unintended?

It is intended. Without that second commit, the website build fails.

@tengqm
Copy link
Contributor Author

tengqm commented Feb 28, 2023

As for the live website, I'll fix it in a separate PR (not the same target branch anyway).

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7dc1d388243fc7351d4e6bf1aef8780c16dcd44e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants