- 
                Notifications
    You must be signed in to change notification settings 
- Fork 15.1k
          Backport cve-feed shortcode to dev-1.26-ko.1 branch
          #39787
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    Backport cve-feed shortcode to dev-1.26-ko.1 branch
  
  #39787
              Conversation
dev-1.26-ko.1 branch
      | ✅ Deploy Preview for k8s-dev-ko ready!
 To edit notification comments on pull requests, go to your Netlify site settings. | 
| The Netlify preview build for this PR succeded without error. Since this PR is touching the files under  | 
| Hi @jihoon-seo When we try to merge dev-1.26-ko.1 into the main branch, the commit in this PR possibly incur a conflict that may require rebasing dev-1.26-ko.1 onto the main. How about cheery-picking the related commits? https://kubernetes.slack.com/archives/CA1MMM1HU/p1677746887238269?thread_ts=1677732886.663289&cid=CA1MMM1HU | 
| @seokho-son please note that this is the cherry-picking PR with the fix commit from #39719. | 
| @jihoon-seo I guess we can minimize conflict with a bare minimum cherry-pick commit from the main when we merge commits in dev-1.26-ko.1 into the main branch. What do you think so ? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/approve
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
| It'd be more useful to merge main into dev-1.26-ko.1 - if that suits the Korean team's workflow. However, this cherry-pick would also work. | 
| 
 Thanks @sftim I think it would be nice to use cherry-pick this time, and look forward to improving the Korean team's workflow. | 
Also add information about last update time on CVE table
d74d846    to
    44334fa      
    Compare
  
    | @sftim Thank you for your approval. @seokho-son as per your comment, I updated this PR to cherry-pick the commit e277fe5 which is in  | 
| Don't worry about the duplicate commits. Git is clever, at least about this sort of thing. | 
| /lgtm | 
| LGTM label has been added. Git tree hash: 8f7e36f7f67147942796c31fbe2453eaad085b0f | 
Hope this PR resolves the cve-feed shortcode-related Netlify build error.
https://app.netlify.com/sites/k8s-dev-ko/deploys/6400e3c038c2f70008c2cd23
dev-1.26-ko.1(M62) #39786:https://app.netlify.com/sites/k8s-dev-ko/deploys/6403e18609f95b0008c26d52