This repository was archived by the owner on Sep 28, 2022. It is now read-only.
KZL - 547 - Update validate specification signature #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2018
Merged
Merged
scottinet
approved these changes
Oct 5, 2018
alexandrebouthinon
force-pushed
the
1-dev
branch
from
9df1074 to
57238bc
Compare
xbill82
approved these changes
Oct 9, 2018
benoitvidis
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before the method
validateSpecificationsdidn't take an index an a collection in parameters and could be used for any collection.This PR change the signature to match the rest of the collection controller. The method now take an index and a collection in addition to the specifications for this collection.
I also modify the
updateSpecificationsmethod. The method was taking an index and collection in parameter but it didn't scope the specifications to the collection.Related PR: kuzzleio/sdk-javascript#318, kuzzleio/sdk-go#211, kuzzleio/sdk-c#13, kuzzleio/sdk-cpp#11, #13, kuzzleio/documentation#51
How should this be manually tested?
./.ci/start_kuzzle.shdocker run --rm -it -e ARCH="amd64" --network ci_default --link kuzzle -v "$(pwd)":/mnt kuzzleio/sdk-cross:openjdk8 bash -c "make clean all test"