KZL-547 - Update validateSpecifications signature to take index and collection #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitvidis
approved these changes
Oct 4, 2018
Codecov Report
@@ Coverage Diff @@
## 6-dev #318 +/- ##
=========================================
- Coverage 97.76% 97.5% -0.27%
=========================================
Files 28 28
Lines 1390 1400 +10
=========================================
+ Hits 1359 1365 +6
- Misses 31 35 +4
Continue to review full report at Codecov.
|
This was referenced Oct 4, 2018
Merged
scottinet
approved these changes
Oct 5, 2018
src/controllers/collection.js
Outdated
| throw new Error('Kuzzle.collection.updateSpecifications: collection is required'); | ||
| } | ||
| if (!specifications) { | ||
| throw new Error('Kuzzle.collection.updateSpecifications: specifications is required'); |
There was a problem hiding this comment.
specifications are required
src/controllers/collection.js
Outdated
| throw new Error('Kuzzle.collection.validateSpecifications: collection is required'); | ||
| } | ||
| if (!specifications) { | ||
| throw new Error('Kuzzle.collection.updateSpecifications: specifications is required'); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before the method
validateSpecificationsdidn't take an index an a collection in parameters and could be used for any collection.This PR change the signature to match the rest of the collection controller. The method now take an index and a collection in addition to the specifications for this collection.
I also modify the
updateSpecificationsmethod. The method was taking an index and collection in parameter but it didn't scope the specifications to the collection.Related PR: #318, kuzzleio/sdk-go#211, kuzzleio/sdk-c#13, kuzzleio/sdk-cpp#11, kuzzleio/sdk-java#13, kuzzleio/documentation#51
How should this be manually tested?
my-indexandmy-collection