Skip to content

Conversation

jenow
Copy link
Contributor

@jenow jenow commented May 24, 2017

According to new login in Kuzzle strategy is not part of the body anymore but in the upper level of the request:

{
  body: {
    username: 'foo',
    password: 'bar'
  },
  strategy: 'local'
}

@jenow jenow self-assigned this May 24, 2017
@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

Merging #221 into 4.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             4.x     #221      +/-   ##
=========================================
+ Coverage   99.4%   99.45%   +0.05%     
=========================================
  Files         16       16              
  Lines       1845     1845              
  Branches     529      529              
=========================================
+ Hits        1834     1835       +1     
+ Misses        11       10       -1
Impacted Files Coverage Δ
src/Kuzzle.js 99.66% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c5509...ed767ed. Read the comment docs.

@scottinet scottinet changed the base branch from 4.x to 5.x May 29, 2017 07:24
@scottinet
Copy link
Contributor

Changed target branch to 5.x

@scottinet
Copy link
Contributor

Changes proposed by this pull request are already there in the 5.x branch. I'm closing this PR.

@scottinet scottinet closed this May 29, 2017
@scottinet scottinet deleted the refactor-login branch May 29, 2017 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants