-
Notifications
You must be signed in to change notification settings - Fork 17
SDK Refactor: server controller #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 6.x #285 +/- ##
=========================================
+ Coverage 84.13% 86.4% +2.27%
=========================================
Files 20 21 +1
Lines 1973 1957 -16
=========================================
+ Hits 1660 1691 +31
+ Misses 313 266 -47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need bluebird to promisify functions.
It would be simpler imo to directly modify query and its dependencies to return a promise (wip on my side)
@benoitvidis As explained in the PR's description, I let the bluebird's promisification for If we modify first the
I personally chose the 2nd option because IMHO, it's a better way for me to make sure each PR don't break methods that are still not rewritten... |
# Conflicts: # src/Kuzzle.js # test/kuzzle/constructor.test.js # test/kuzzle/methods.test.js # webpack.config.js
@benoitvidis @jenow you may want to review this PR again. |
replaced by #290 |
fix https://github.com/kuzzleio/kuzzle-backlog/issues/101