Skip to content

SDK Refactor : match API structure #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Jun 5, 2018
Merged

SDK Refactor : match API structure #290

merged 48 commits into from
Jun 5, 2018

Conversation

ballinette
Copy link

@ballinette ballinette commented Mar 28, 2018 •
edited
Loading

@ballinette ballinette added the wip label Mar 28, 2018
Ballinette added 18 commits March 28, 2018 16:17
nitpicking
522baa3
re-add package-lock.json (previously removed by error by #286)
213afe9
ServerController: add jsdocs
20b9a5c
ServerController: add getStats method
ca8c834
fix request.refresh argument
066c032
inject kuzzle's volatile into requests
502b82b
remove defaultIndex
c7f189d
remove obsolete unit tests on removed features
8400f14
unit-tests on security objects
ff5d847
Refactor unit-tests for network protocols and query management
0e417d4
refactor unit-tests for Kuzzle constructor, getters and setters
beead5f
fix kuzzle.connect unit tests
8c808c8
fix unit tests for kuzzle eventEmitter/listener management
cd080ef
fix unit tests for Kuzze netowrk methods
62903a1
fix unit tests for kuzzle query management
2693ddd
fix linter
3de1d6e
fix unit-test for memoryStorage controller
2951926
fix unit tests for auth controller
df413fa
@codecov-io
Copy link

codecov-io commented Apr 13, 2018 •
edited
Loading

Codecov Report

Merging #290 into 6.x will increase coverage by 10.78%.
The diff coverage is 96.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##              6.x     #290       +/-   ##
===========================================
+ Coverage   84.13%   94.92%   +10.78%     
===========================================
  Files          20       28        +8     
  Lines        1973     1319      -654     
===========================================
- Hits         1660     1252      -408     
+ Misses        313       67      -246
Impacted Files Coverage Δ
src/networkWrapper/index.js 90% <ø> (ø) ⬆️
src/controllers/document.js 100% <100%> (ø)
src/controllers/realtime/room.js 100% <100%> (ø)
src/networkWrapper/protocols/abstract/realtime.js 96.96% <100%> (+44.58%) ⬆️
src/controllers/realtime/index.js 100% <100%> (ø)
src/controllers/searchResult/specifications.js 100% <100%> (ø)
src/networkWrapper/protocols/socketio.js 96.29% <100%> (+0.29%) ⬆️
src/Kuzzle.js 99.29% <100%> (+53.43%) ⬆️
src/controllers/bulk.js 100% <100%> (ø)
src/controllers/security/user.js 100% <100%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f24bd9...e62a1b1. Read the comment docs.

@ballinette ballinette mentioned this pull request Apr 25, 2018
Closed
@ballinette ballinette changed the title SDK Refactor SDK Refactor : match API structure May 22, 2018
@ballinette ballinette merged commit 1e5b4c7 into 6.x Jun 5, 2018
@scottinet scottinet deleted the feature/sdk-refactor branch June 29, 2018 07:21
@alexandrebouthinon alexandrebouthinon mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandrebouthinon alexandrebouthinon alexandrebouthinon approved these changes

+1 more reviewer

@benoitvidis benoitvidis benoitvidis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog:breaking-changes changelog:enhancements need-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ballinette @codecov-io @benoitvidis @alexandrebouthinon