Skip to content

remove unused properties #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

remove unused properties #313

merged 1 commit into from
Sep 19, 2018

Conversation

benoitvidis
Copy link
Contributor

What does this PR do?

This PR removes some unused properties from the SDK

  1. Kuzzle.network.id is never used. Further, being defined in the module scope, its value would have been the same between several Kuzzle isntances sharing the same require
  2. The attempt to make the getters enumerable just don't work.

@scottinet scottinet merged commit 75f3e63 into 6-dev Sep 19, 2018
@scottinet scottinet deleted the remove-unused-props branch September 19, 2018 07:47
@jenow jenow mentioned this pull request Sep 25, 2018
Merged
scottinet pushed a commit that referenced this pull request Sep 26, 2018
@jenow @scottinet
Release 6.0.0-beta-2 (#316)
362a326 
* Rename deleteSpecification to deleteSpecifications

* remove unused properties (#313)

* fix jwt in query (#315)

* Release 6.0.0-beta-2
@alexandrebouthinon alexandrebouthinon mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Aschen Aschen Aschen approved these changes

@scottinet scottinet scottinet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benoitvidis benoitvidis

Labels

changelog:enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benoitvidis @Aschen @scottinet