Skip to content

fix jwt in query #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

fix jwt in query #315

merged 1 commit into from
Sep 25, 2018

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Sep 25, 2018 •
edited
Loading

What does this PR do?

Fix a bug where the JWT would not be set if the controller would be auth and the action different from checkToken

@jenow jenow self-assigned this Sep 25, 2018
@codecov-io
Copy link

Codecov Report

Merging #315 into 6-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            6-dev     #315   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          28       28           
  Lines        1390     1390           
=======================================
  Hits         1359     1359           
  Misses         31       31
Impacted Files Coverage Δ
src/Kuzzle.js 99.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f3e63...bb8e5ee. Read the comment docs.

@Aschen Aschen merged commit 447fb6f into 6-dev Sep 25, 2018
@Aschen Aschen deleted the fix-jwt-in-query branch September 25, 2018 08:49
@jenow jenow mentioned this pull request Sep 25, 2018
Merged
scottinet pushed a commit that referenced this pull request Sep 26, 2018
@jenow @scottinet
Release 6.0.0-beta-2 (#316)
362a326 
* Rename deleteSpecification to deleteSpecifications

* remove unused properties (#313)

* fix jwt in query (#315)

* Release 6.0.0-beta-2
@alexandrebouthinon alexandrebouthinon mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ballinette ballinette ballinette approved these changes

@Aschen Aschen Aschen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jenow jenow

Labels

changelog:bug-fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jenow @codecov-io @ballinette @Aschen