[fix] search API: "sort" and "search_after" must be in the requests body #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6-dev #384 +/- ##
==========================================
+ Coverage 96.73% 96.73% +<.01%
==========================================
Files 30 30
Lines 1438 1439 +1
==========================================
+ Hits 1391 1392 +1
Misses 47 47
Continue to review full report at Codecov.
|
Yoann-Abbes
reviewed
Apr 8, 2019
| const key = typeof sort === 'string' | ||
| ? sort | ||
| : Object.keys(sort)[0]; | ||
| const value = key === '_uid' |
There was a problem hiding this comment.
(nitpicking) maybe adding parentheses make it more readable
Suggested change
| const value = key === '_uid' | |
| const value = (key === '_uid') |
Yoann-Abbes
reviewed
Apr 8, 2019
| request.body.search_after = []; | ||
|
|
||
| for (const sort of this._request.body.sort) { | ||
| const key = typeof sort === 'string' |
There was a problem hiding this comment.
(nitpicking) maybe adding parentheses here make it more readable
Suggested change
| const key = typeof sort === 'string' | |
| const key = (typeof sort === 'string') |
Yoann-Abbes
approved these changes
Apr 8, 2019
ballinette
approved these changes
Apr 8, 2019
benoitvidis
approved these changes
Apr 8, 2019
Aschen
pushed a commit
that referenced
this pull request
Apr 29, 2019
# [6.1.1](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.1.1) (2019-04-29) #### Bug fixes - [ [#384](#384) ] [fix] search API: "sort" and "search_after" must be in the requests body ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#388](#388) ] Use BaseController class for controllers ([Aschen](https://github.com/Aschen)) - [ [#385](#385) ] Add Realtime.createRestrictedUser method ([Aschen](https://github.com/Aschen)) #### Others - [ [#387](#387) ] SearchResult.next returns a new instance ([Aschen](https://github.com/Aschen)) ---
Merged
Aschen
added a commit
that referenced
this pull request
Jun 14, 2019
Release 6.1.2
Bug fixes
[ #398 ] Fix bulk return (Aschen)
[ #394 ] Add default values for from/size to document:search (Aschen)
[ #384 ] Fix search API: "sort" and "search_after" must be in the requests body (scottinet)
Enhancements
[ #390 ] Add authenticated property on Kuzzle object (Aschen)
[ #395 ] Proxify kuzzle to avoid mistyping error (thomasarbona)
[ #389 ] Remove usage of _meta (Aschen)
[ #391 ] Add isConnected (Aschen)
[ #388 ] Use BaseController class for controllers (Aschen)
[ #385 ] Add Security.createRestrictedUser method (Aschen)
Others
[ #400 ] Fix large document search using scroll (stafyniaksacha)
[ #387 ] SearchResult.next returns a new instance (Aschen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SearchResultclass sends asearch_afterrequest to Kuzzle upon calling itsnextmethod, if:sizeoption is providedsortmodifierThe current implementation considers that
sortmust be at the root of the API request, while Kuzzle expects it inside the body part of it.Same thing goes for the
search_afterargument, which must be put in the request body, not at root level.