Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Apr 26, 2019

What does this PR do?

Remove the usage of _meta property.

This is not a breaking change since this property wasn't documented

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #389 into 6-dev will decrease coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #389      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files          30       30              
  Lines        1443     1442       -1     
==========================================
- Hits         1392     1391       -1     
  Misses         51       51
Impacted Files Coverage Δ
src/controllers/auth.js 93.02% <100%> (ø) ⬆️
src/controllers/security/profile.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/user.js 100% <100%> (ø) ⬆️
src/controllers/security/user.js 100% <100%> (ø) ⬆️
src/controllers/security/index.js 99.58% <100%> (ø) ⬆️
src/controllers/security/role.js 80% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1888d...3008ea2. Read the comment docs.

Copy link
Member

@alexandrebouthinon alexandrebouthinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discuss in core-team slack channel

@scottinet
Copy link
Contributor

@stafyniaksacha > the meta are still there, in User.content._kuzzle_info, it's just the undocumented and redundant User.meta property that is being removed (I had the same reaction than you initially).

@scottinet scottinet merged commit cd684cc into 6-dev May 17, 2019
@scottinet scottinet deleted the remove-kuzzle-meta branch May 17, 2019 09:30
@Aschen Aschen mentioned this pull request Jun 14, 2019
Aschen added a commit that referenced this pull request Jun 14, 2019
Release 6.1.2

Bug fixes

    [ #398 ] Fix bulk return (Aschen)
    [ #394 ] Add default values for from/size to document:search (Aschen)
    [ #384 ] Fix search API: "sort" and "search_after" must be in the requests body (scottinet)

Enhancements

    [ #390 ] Add authenticated property on Kuzzle object (Aschen)
    [ #395 ] Proxify kuzzle to avoid mistyping error (thomasarbona)
    [ #389 ] Remove usage of _meta (Aschen)
    [ #391 ] Add isConnected (Aschen)
    [ #388 ] Use BaseController class for controllers (Aschen)
    [ #385 ] Add Security.createRestrictedUser method (Aschen)

Others

    [ #400 ] Fix large document search using scroll (stafyniaksacha)
    [ #387 ] SearchResult.next returns a new instance (Aschen)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants