Fix incompatibility with ES6 Javascript #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasarbona
approved these changes
Jun 14, 2019
alexandrebouthinon
approved these changes
Jun 14, 2019
scottinet
suggested changes
Jun 14, 2019
scottinet
approved these changes
Jun 14, 2019
scottinet
changed the title
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 32 32
Lines 1519 1519
=======================================
Hits 1463 1463
Misses 56 56
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Proxify module use the object spread operator.
Kuzzle use the Javascript SDK and we keep es5 compat so we have to keep the SDK Javascript es6compatible too.