Add document:upsert #576
Merged
Add document:upsert #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #576 +/- ##
==========================================
- Coverage 88.28% 87.61% -0.67%
==========================================
Files 32 32
Lines 1451 1462 +11
Branches 254 261 +7
==========================================
Hits 1281 1281
- Misses 120 130 +10
- Partials 50 51 +1
Continue to review full report at Codecov.
|
scottinet
suggested changes
Dec 18, 2020
Co-authored-by: Sébastien Cottinet <[email protected]>
Co-authored-by: Sébastien Cottinet <[email protected]>
Aschen
suggested changes
Dec 29, 2020
| | `index` | <pre>string</pre> | Index name | | ||
| | `collection` | <pre>string</pre> | Collection name | | ||
| | `id` | <pre>string</pre> | Document ID | | ||
| | `body` | <pre>object</pre> | Partial content of the document to update and fields to add to the document if it gets created | |
There was a problem hiding this comment.
This doesn't match method signature
src/controllers/Document.ts
Outdated
| * @param _id Unique document identifier | ||
| * @param body Partial changes to apply to the document and Fields to add to the document if it gets created (optional) | ||
| * @param options | ||
| * @returns {Promise<Object>} |
There was a problem hiding this comment.
Suggested change
| * @returns {Promise<Object>} | |
| * @returns Information about the updated document |
src/controllers/Document.ts
Outdated
| * @param body Partial changes to apply to the document and Fields to add to the document if it gets created (optional) | ||
| * @param options | ||
| * @returns {Promise<Object>} | ||
| * @see https://docs.kuzzle.io/sdk/js/7/controllers/document/upsert/ |
There was a problem hiding this comment.
This should be between the description and params description
src/controllers/Document.ts
Outdated
| collection: string, | ||
| _id: string, | ||
| body: JSONObject, | ||
| options: {refresh?: string, retryOnConflict?: boolean, source?: boolean} = {} |
There was a problem hiding this comment.
retryOnConflict is not added to the request. Since this is a common argument, you should check for it's presence in the Kuzzle.query method and add it if present (this bug already exists in prior version of the SDK)
Aschen
suggested changes
Dec 30, 2020
| --- | ||
| code: true | ||
| type: page | ||
| title: upsert |
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
xbill82
approved these changes
Jan 5, 2021
scottinet
approved these changes
Jan 6, 2021
Co-authored-by: Sébastien Cottinet <[email protected]>
Aschen
approved these changes
Jan 11, 2021
Merged
Aschen
added a commit
that referenced
this pull request
Jan 17, 2021
# [7.5.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.5.0) (2021-01-17) #### New features - [ [#577](#577) ] Add [auth|security]:checkRights ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#576](#576) ] Add document:upsert ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add document:upsert API action (fix #572)