Add [auth|security]:checkRights #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #577 +/- ##
==========================================
- Coverage 88.28% 87.61% -0.67%
==========================================
Files 32 32
Lines 1451 1462 +11
Branches 254 259 +5
==========================================
Hits 1281 1281
- Misses 120 131 +11
Partials 50 50
Continue to review full report at Codecov.
|
Aschen
suggested changes
Dec 17, 2020
There was a problem hiding this comment.
I'm sorry Kuzzle documentation was not accurate, can you correct this PR with the new doc ?
kuzzleio/kuzzle#1912
Also can you choose better names for method arguments since they will be displayed in the editor with the jsdoc
Co-authored-by: Adrien Maret <[email protected]>
Njuelle
approved these changes
Dec 22, 2020
rolljee
approved these changes
Dec 23, 2020
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Aschen
suggested changes
Dec 29, 2020
doc/7/controllers/security/check-rights/snippets/check-rights.test.yml
Outdated
Show resolved
Hide resolved
doc/7/controllers/security/check-rights/snippets/check-rights.js
Outdated
Show resolved
Hide resolved
doc/7/controllers/security/check-rights/snippets/check-rights.js
Outdated
Show resolved
Hide resolved
doc/7/controllers/security/check-rights/snippets/check-rights.js
Outdated
Show resolved
Hide resolved
|
|
||
| ## Resolves | ||
|
|
||
| The returned result contains the following property: |
There was a problem hiding this comment.
The allowed boolean is directly returned
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
…test.yml Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
rolljee
approved these changes
Dec 29, 2020
Njuelle
approved these changes
Jan 7, 2021
Aschen
reviewed
Jan 11, 2021
Aschen
approved these changes
Jan 11, 2021
Merged
Aschen
added a commit
that referenced
this pull request
Jan 17, 2021
# [7.5.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.5.0) (2021-01-17) #### New features - [ [#577](#577) ] Add [auth|security]:checkRights ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#576](#576) ] Add document:upsert ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add [auth|security]:checkRights #571
How should this be manually tested?
...
Other changes
Boyscout