Skip to content

chore: remove useless code #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

chore: remove useless code #5629

merged 3 commits into from
Sep 12, 2025

Conversation

@FinleyGe
Copy link
Collaborator

@FinleyGe FinleyGe commented Sep 12, 2025

No description provided.

@gru-agent
Copy link
Contributor

gru-agent bot commented Sep 12, 2025 •
edited
Loading

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 18e5a7b ✅ Finished

History Assignment

Files

File Pull Request
projects/app/src/pages/api/core/app/update.ts ❌ Failed (The test job failed because the test file could not import the source file due to an environmental path resolution issue. The error message indicates that Vitest could not resolve the relative path '../../../../projects/app/src/pages/api/core/app/update' from the test file location. This is not a bug in the source code or the test code, but rather a problem with the test runner's configuration or the file system layout. No unit test or source code bug is responsible for this failure.)
projects/app/src/pages/api/core/dataset/update.ts ❌ Failed (The test job failed due to module resolution or environmental issues, not because of a bug in the source code. The error message indicates that Vitest could not resolve or load the source file '../../../../projects/app/src/pages/api/core/dataset/update' when running the test. This is likely due to a misconfiguration in the test environment, incorrect file paths, or missing files, rather than a problem with the code logic itself. The tests themselves are valid and do not indicate a source code bug.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Preview mcp_server Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_mcp_server_bbbf70d66fcc266563abbb6e6fd5944d01bb7615

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Preview sandbox Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_sandbox_bbbf70d66fcc266563abbb6e6fd5944d01bb7615

@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Preview fastgpt Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_bbbf70d66fcc266563abbb6e6fd5944d01bb7615

@FinleyGe FinleyGe force-pushed the refactor/inherit-permission branch from 2bb9d9a to 4bcdba6 Compare September 12, 2025 09:23
@c121914yu c121914yu merged commit 3651ef7 into labring:v4.12.4-dev Sep 12, 2025
5 checks passed
c121914yu pushed a commit that referenced this pull request Sep 14, 2025
@FinleyGe @c121914yu
chore: remove useless code (#5629)
30fac83 
* chore: remove useless code

* fix: checkConflict

* perf: support hidden type for RoleList
c121914yu added a commit that referenced this pull request Sep 15, 2025
@c121914yu @fishwww-ww
@FinleyGe @newfish-cmyk @xqvvu
V4.12.4 features (#5626)
2ed1545 
* fix: push again, user select option button and form input radio content overflow (#5601)

* fix: push again, user select option button and form input radio content overflow

* fix: use useCallback instead of useMemo, fix unnecessary delete

* fix: Move the variable inside the component

* fix: do not pass valueLabel to MySelect

* ui

* del collection api adapt

* refactor: inherit permission (#5529)

* refactor: permission update conflict check function

* refactor(permission): app collaborator update api

* refactor(permission): support app update collaborator

* feat: support fe permission conflict check

* refactor(permission): app permission

* refactor(permission): dataset permission

* refactor(permission): team permission

* chore: fe adjust

* fix: type error

* fix: audit pagiation

* fix: tc

* chore: initv4130

* fix: app/dataset auth logic

* chore: move code

* refactor(permission): remove selfPermission

* fix: mock

* fix: test

* fix: app & dataset auth

* fix: inherit

* test(inheritPermission): test syncChildrenPermission

* prompt editor add list plugin (#5620)

* perf: search result (#5608)

* fix: table size (#5598)

* temp: list value

* backspace

* optimize code

---------

Co-authored-by: Archer <[email protected]>
Co-authored-by: 伍闲犬 <[email protected]>

* fix: fe & member list (#5619)

* chore: initv4130

* fix: MemberItemCard

* fix: MemberItemCard

* chore: fe adjust & init script

* perf: test code

* doc

* fix debug variables (#5617)

* perf: search result (#5608)

* fix: table size (#5598)

* fix debug variables

* fix

---------

Co-authored-by: Archer <[email protected]>
Co-authored-by: 伍闲犬 <[email protected]>

* perf: member ui

* fix: inherit bug (#5624)

* refactor(permission): remove getClbsWithInfo, which is useless

* fix: app list privateApp

* fix: get infos

* perf(fe): remove delete icon when it is disable in MemberItemCard

* fix: dataset private dataset

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Archer <[email protected]>
Co-authored-by: Copilot <[email protected]>

* perf: auto coupon

* chore: upgrade script & get infos avatar  (#5625)

* fix: get infos

* chore: initv4130

* feat: support WecomRobot publish, and fix AesKey can not save bug (#5526)

* feat: resolve conflicts

* fix: add param 'show_publish_wecom'

* feat: abstract out WecomCrypto type

* doc: wecom robot document

* fix: solve instability in AI output

* doc: update some pictures

* feat: remove functions from request.ts to chat.ts and toolCall.ts

* doc: wecom robot doc update

* fix

* delete unused code

* doc: update version and prompt

* feat: remove wecom crypto, delete wecom code in workflow

* feat: delete unused codes

---------

Co-authored-by: heheer <[email protected]>

* remove test

* rename init shell

* feat: collection page store

* reload sandbox

* pysandbox

* remove log

* chore: remove useless code (#5629)

* chore: remove useless code

* fix: checkConflict

* perf: support hidden type for RoleList

* fix: copy node

* update doc

* fix(permission): some bug (#5632)

* fix: app/dataset list

* fix: inherit bug

* perf: del app;i18n;save chat

* fix: test

* i18n

* fix: sumper overflow return OwnerRoleVal (#5633)

* remove invalid code

* fix: scroll

* fix: objectId

* update next

* update package

* object id

* mock redis

* feat: add redis append to resolve wecom stream response  (#5643)

* feat: resolve conflicts

* fix: add param 'show_publish_wecom'

* feat: abstract out WecomCrypto type

* doc: wecom robot document

* fix: solve instability in AI output

* doc: update some pictures

* feat: remove functions from request.ts to chat.ts and toolCall.ts

* doc: wecom robot doc update

* fix

* delete unused code

* doc: update version and prompt

* feat: remove wecom crypto, delete wecom code in workflow

* feat: delete unused codes

* feat: add redis append method

---------

Co-authored-by: heheer <[email protected]>

* cache per

* fix(test): init team sub when creating mocked user (#5646)

* fix: button is not vertically centered (#5647)

* doc

* fix: gridFs objectId (#5649)

---------

Co-authored-by: Zeng Qingwen <[email protected]>
Co-authored-by: Finley Ge <[email protected]>
Co-authored-by: heheer <[email protected]>
Co-authored-by: 伍闲犬 <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: heheer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c121914yu c121914yu c121914yu approved these changes

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FinleyGe @c121914yu