fix(permission): some bug #5632

FinleyGe · 2025-09-12T17:01:15Z

fix: app/dataset list
fix: inherit bug

gru-agent · 2025-09-12T17:01:26Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`667ca23`	🚫 Skipped	No files need to be tested {"packages/global/support/permission/utils.ts":"File path does not match include patterns.","projects/app/src/components/support/permission/MemberManager/MemberItemCard.tsx":"File path does not match include patterns.","projects/app/src/components/support/permission/MemberManager/MemberModal.tsx":"File path does not match include patterns.","projects/app/src/components/support/permission/MemberManager/RoleSelect.tsx":"File path does not match include patterns.","projects/app/src/components/support/permission/MemberManager/context.tsx":"File path does not match include patterns.","projects/app/src/pageComponents/dashboard/apps/List.tsx":"File path does not match include patterns.","projects/app/src/pages/api/core/app/list.ts":"Can not find valuable test target.\nhandler: Out of scope - The handler function involves complex interactions between multiple modules, services, and external dependencies such as database queries, authentication, and permission checks.…

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

github-actions · 2025-09-12T17:03:25Z

Preview mcp_server Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_mcp_server_667ca23fade35358695aa5483350f5418d21a6a5

github-actions · 2025-09-12T17:03:33Z

Preview sandbox Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_sandbox_667ca23fade35358695aa5483350f5418d21a6a5

github-actions · 2025-09-12T17:08:05Z

Preview fastgpt Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_667ca23fade35358695aa5483350f5418d21a6a5

Copilot

Pull Request Overview

This PR fixes permission-related bugs in the app and dataset list APIs, specifically addressing inherit permission functionality and role calculation issues.

Key changes:

Improved permission inheritance by combining parent and child permissions using addRole
Renamed groupRole to groupAndOrgRole for better clarity across permission handling
Simplified role selection logic in the UI components

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
projects/app/src/pages/api/core/dataset/list.ts	Fixed permission inheritance and renamed role variable for clarity
projects/app/src/pages/api/core/app/list.ts	Applied similar permission fixes and variable renaming as dataset list
projects/app/src/pageComponents/dashboard/apps/List.tsx	Removed unused import for cleaner code
projects/app/src/components/support/permission/MemberManager/context.tsx	Added isInheritPermission context property
projects/app/src/components/support/permission/MemberManager/RoleSelect.tsx	Simplified role selection by removing unnecessary permission manipulation
projects/app/src/components/support/permission/MemberManager/MemberModal.tsx	Enhanced member permission handling with inheritance logic
projects/app/src/components/support/permission/MemberManager/MemberItemCard.tsx	Removed unused imports
packages/global/support/permission/utils.ts	Fixed role conflict checking logic

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-12T17:08:30Z

packages/global/support/permission/utils.ts

  const changedClbs = getChangedCollaborators({
    newRealClbs: newChildClbs,
-    oldRealClbs: oldRealClbs
+    oldRealClbs: parentClbs


The parameter passed to getChangedCollaborators should be oldRealClbs as originally passed, not parentClbs. This change breaks the function's logic by comparing parent collaborators against themselves instead of comparing old vs new collaborators.

Suggested change

oldRealClbs: parentClbs

oldRealClbs: oldRealClbs

* fix: app/dataset list * fix: inherit bug

* fix: push again, user select option button and form input radio content overflow (#5601) * fix: push again, user select option button and form input radio content overflow * fix: use useCallback instead of useMemo, fix unnecessary delete * fix: Move the variable inside the component * fix: do not pass valueLabel to MySelect * ui * del collection api adapt * refactor: inherit permission (#5529) * refactor: permission update conflict check function * refactor(permission): app collaborator update api * refactor(permission): support app update collaborator * feat: support fe permission conflict check * refactor(permission): app permission * refactor(permission): dataset permission * refactor(permission): team permission * chore: fe adjust * fix: type error * fix: audit pagiation * fix: tc * chore: initv4130 * fix: app/dataset auth logic * chore: move code * refactor(permission): remove selfPermission * fix: mock * fix: test * fix: app & dataset auth * fix: inherit * test(inheritPermission): test syncChildrenPermission * prompt editor add list plugin (#5620) * perf: search result (#5608) * fix: table size (#5598) * temp: list value * backspace * optimize code --------- Co-authored-by: Archer <[email protected]> Co-authored-by: 伍闲犬 <[email protected]> * fix: fe & member list (#5619) * chore: initv4130 * fix: MemberItemCard * fix: MemberItemCard * chore: fe adjust & init script * perf: test code * doc * fix debug variables (#5617) * perf: search result (#5608) * fix: table size (#5598) * fix debug variables * fix --------- Co-authored-by: Archer <[email protected]> Co-authored-by: 伍闲犬 <[email protected]> * perf: member ui * fix: inherit bug (#5624) * refactor(permission): remove getClbsWithInfo, which is useless * fix: app list privateApp * fix: get infos * perf(fe): remove delete icon when it is disable in MemberItemCard * fix: dataset private dataset * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Archer <[email protected]> Co-authored-by: Copilot <[email protected]> * perf: auto coupon * chore: upgrade script & get infos avatar (#5625) * fix: get infos * chore: initv4130 * feat: support WecomRobot publish, and fix AesKey can not save bug (#5526) * feat: resolve conflicts * fix: add param 'show_publish_wecom' * feat: abstract out WecomCrypto type * doc: wecom robot document * fix: solve instability in AI output * doc: update some pictures * feat: remove functions from request.ts to chat.ts and toolCall.ts * doc: wecom robot doc update * fix * delete unused code * doc: update version and prompt * feat: remove wecom crypto, delete wecom code in workflow * feat: delete unused codes --------- Co-authored-by: heheer <[email protected]> * remove test * rename init shell * feat: collection page store * reload sandbox * pysandbox * remove log * chore: remove useless code (#5629) * chore: remove useless code * fix: checkConflict * perf: support hidden type for RoleList * fix: copy node * update doc * fix(permission): some bug (#5632) * fix: app/dataset list * fix: inherit bug * perf: del app;i18n;save chat * fix: test * i18n * fix: sumper overflow return OwnerRoleVal (#5633) * remove invalid code * fix: scroll * fix: objectId * update next * update package * object id * mock redis * feat: add redis append to resolve wecom stream response (#5643) * feat: resolve conflicts * fix: add param 'show_publish_wecom' * feat: abstract out WecomCrypto type * doc: wecom robot document * fix: solve instability in AI output * doc: update some pictures * feat: remove functions from request.ts to chat.ts and toolCall.ts * doc: wecom robot doc update * fix * delete unused code * doc: update version and prompt * feat: remove wecom crypto, delete wecom code in workflow * feat: delete unused codes * feat: add redis append method --------- Co-authored-by: heheer <[email protected]> * cache per * fix(test): init team sub when creating mocked user (#5646) * fix: button is not vertically centered (#5647) * doc * fix: gridFs objectId (#5649) --------- Co-authored-by: Zeng Qingwen <[email protected]> Co-authored-by: Finley Ge <[email protected]> Co-authored-by: heheer <[email protected]> Co-authored-by: 伍闲犬 <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: heheer <[email protected]>

FinleyGe added 2 commits September 12, 2025 23:13

fix: app/dataset list

af41856

fix: inherit bug

667ca23

pull-request-size bot added the size/L label Sep 12, 2025

c121914yu approved these changes Sep 12, 2025

View reviewed changes

c121914yu requested a review from Copilot September 12, 2025 17:08

Copilot AI reviewed Sep 12, 2025

View reviewed changes

c121914yu approved these changes Sep 12, 2025

View reviewed changes

c121914yu merged commit 23a9c11 into labring:v4.12.4-dev Sep 12, 2025
4 of 5 checks passed

c121914yu pushed a commit that referenced this pull request Sep 14, 2025

fix(permission): some bug (#5632)

4e52e54

* fix: app/dataset list * fix: inherit bug

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(permission): some bug #5632

fix(permission): some bug #5632

Uh oh!

FinleyGe commented Sep 12, 2025

Uh oh!

gru-agent bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(permission): some bug #5632

fix(permission): some bug #5632

Uh oh!

Conversation

FinleyGe commented Sep 12, 2025

Uh oh!

gru-agent bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Uh oh!

github-actions bot commented Sep 12, 2025

Preview mcp_server Image:

Uh oh!

github-actions bot commented Sep 12, 2025

Preview sandbox Image:

Uh oh!

github-actions bot commented Sep 12, 2025

Preview fastgpt Image:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gru-agent bot commented Sep 12, 2025 •

edited

Loading