-
Notifications
You must be signed in to change notification settings - Fork 768
Support audio device for vz driver #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Balaji Vijayakumar <[email protected]>
|
Does vz also have a dummy driver, that presents an audio device but doesn't do any sound ? If so, it could be connected to the "none" value |
| if err != nil { | ||
| return err | ||
| } | ||
| inputStream, err := vz.NewVirtioSoundDeviceHostInputStreamConfiguration() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't configure any input stream for qemu, but that is probably a good idea... maybe a boolean ? or not
Think it should be enough (for qemu) to swap hda-output for hda-duplex for the HDA Audio Codec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine as QEMU directly has a device that support both. But i haven't tested microphone case.
I think it needs some permission (NSMicrophoneUsageDescription) in Info.plist. Checking on how to provide that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just verified Microphone as well, it is working without any extra Info.plist. Not sure how but working :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just verified Microphone as well, it is working without any extra Info.plist. Not sure how but working :D
I suspect you allowed your terminal to access the microphone, so all processes started from it will inherit this right. Just like when you give the terminal full disk access, all child processes have full access as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this makes a lot of sense.
Thanks for the clarification 😃
AkihiroSuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No vz doesn't have a dummy driver |
Fixes #1531
Had to do some setup to configure audio. Steps are as follows,
linux-image-extra-virtualto enable virtio-sndaplay -lto verify if device is shownalsa-utilsusermod -a -G audio <user>speaker-test -t wavand verify audio workingNote: These are the steps worked for me, there might be some simplified steps to configure as well.