Add audio input to qemu in order to match vz #1536
Conversation
Signed-off-by: Anders F Björklund <[email protected]>
| args = append(args, "-device", "ich9-intel-hda") | ||
| // audio codec | ||
| args = append(args, "-device", fmt.Sprintf("hda-output,audiodev=%s", id)) | ||
| args = append(args, "-device", fmt.Sprintf("hda-duplex,audiodev=%s", id)) |
There was a problem hiding this comment.
Could you update the comment in default.yaml?
Also wondering if we can have a YAML property to disable the audio input
There was a problem hiding this comment.
A boolean could be added, not sure how to implement it for vz though
There was a problem hiding this comment.
VZ implementation can be another PR
There was a problem hiding this comment.
We can just make that audio inputstream conditional based on the flag. If we decide on a flag i can do the same in another PR
There was a problem hiding this comment.
What should we do with this for v0.16.0?
There was a problem hiding this comment.
My take would be we can support both for now as by default (as we have support for this in both drivers).
Later if we get any usecase for disabling input we will be able to easily provide at that point of time
There was a problem hiding this comment.
For security I'd prefer to disable input by default
There was a problem hiding this comment.
Ah yes, i missed the security point. It makes sense.
I will create a PR for vz to support the same.
There was a problem hiding this comment.
ok, so then we are good for qemu ?
3 participants
PR #1532
Follow-up: