add support for api_key authentication #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
karenzone
reviewed
May 29, 2020
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
One comment inline. Otherwise, builds cleanly and LGTM.
yaauie
reviewed
May 29, 2020
karenzone
reviewed
May 29, 2020
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
If you accept suggested text, a formatting change is needed for it to render correctly.
Contributor
Author
|
@yaauie @karenzone thanks for the review! - I pushed the discussed changes. |
Contributor
Author
|
unrelated integration test failures, merging. |
Contributor
Author
|
v3.8.0 published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic/logstash#11788
api_keyoptionuser/password,cloud_authandapi_key)