Skip to content

add support for api_key authentication #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

add support for api_key authentication #131

merged 2 commits into from
Jun 3, 2020

Conversation

@colinsurprenant
Copy link
Contributor

@colinsurprenant colinsurprenant commented May 29, 2020

This is currently based on #128 which is pending LGTM - I will rebase once merged.

Related to elastic/logstash#11788

  • Add support for elasticsearch API key authentication using the api_key option
    • SSL must be enabled
    • Only one authentication method must be specified out of (user/password, cloud_auth and api_key)

@colinsurprenant colinsurprenant mentioned this pull request May 29, 2020
Closed
6 tasks
@elasticsearch-bot elasticsearch-bot self-assigned this May 29, 2020
@colinsurprenant colinsurprenant changed the title add support for api_key add support for api_key authentication May 29, 2020
yaauie
yaauie reviewed May 29, 2020
View reviewed changes
karenzone
karenzone reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a simple formatting change to suggested content to make it render correctly. Thanks for the ping!

@colinsurprenant
Copy link
Contributor Author

colinsurprenant commented Jun 1, 2020

@yaauie @karenzone thanks for the review! - I pushed the discussed changes.

yaauie
yaauie approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinsurprenant colinsurprenant changed the base branch from clear_scroll to master June 3, 2020 14:45
@colinsurprenant
Copy link
Contributor Author

colinsurprenant commented Jun 3, 2020

unrelated integration test failures, merging.

@colinsurprenant colinsurprenant merged commit 17e10be into logstash-plugins:master Jun 3, 2020
@colinsurprenant
Copy link
Contributor Author

colinsurprenant commented Jun 3, 2020

v4.7.0 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenzone karenzone karenzone left review comments

@yaauie yaauie yaauie approved these changes

Assignees

@colinsurprenant colinsurprenant

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colinsurprenant @yaauie @karenzone @elasticsearch-bot