Add robustness around scrolling #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinsurprenant
changed the title
Contributor
Author
|
Build errors to investigate. |
yaauie
reviewed
May 26, 2020
Contributor
yaauie
left a comment
yaauie
left a comment
There was a problem hiding this comment.
Approach makes sense. I've added some minor commentary.
Of the two build failures, one was around the scheduler (I've triggered a re-run) and the other appears related to pending breaking changes with types removal in Elasticsearch 8.x.
Contributor
Author
|
Thanks for the review @yaauie - added your suggestions. |
yaauie
approved these changes
Jun 1, 2020
Contributor
yaauie
left a comment
yaauie
left a comment
There was a problem hiding this comment.
LGTM with one optional suggestion.
…oll_request exceptions
colinsurprenant
force-pushed
the
clear_scroll
branch
from
c68f3c0 to
9646c4d
Compare
Contributor
Author
|
Thanks @yaauie for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
clear_scrollAPI after each search operation