Adds elastic-transport client support #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art using newer ES ruby client.
6 tasks
mashhurs
commented
Mar 4, 2025
|
|
||
| def get_transport_client_class | ||
| require "elasticsearch/transport/transport/http/manticore" | ||
| require_relative "elasticsearch/patches/_elasticsearch_transport_http_manticore" |
There was a problem hiding this comment.
review note:
_elasticsearch_transport_http_manticoresets
set user-agent and accept-encoding headers for the es-transport-client versions between 7.2 and 7.16. It seems to me we can remove this but I have kept so far as there are active 7.x users;_elasticsearch_transport_connections_selectorhas a round-robin load balancer logic for the es-client versions <7.2.0
I have kept them for now but it looks to me we can remove.
Closed
jsvd
reviewed
Mar 11, 2025
There was a problem hiding this comment.
This is a good opportunity to be more explicit about the versions of es ruby this plugin supports, so instead of:
s.add_runtime_dependency 'elasticsearch', '>= 7.17.9'
we could do
s.add_runtime_dependency 'elasticsearch', '>= 7.17.9', '< 9'
as we haven't tested with 9 at all.
| end | ||
| end | ||
|
|
||
| def get_transport_client_class |
There was a problem hiding this comment.
let's add a comment here explaining what's happening
…ments on the logics to support both elasticsearch and elastic transport gems.
Co-authored-by: João Duarte <[email protected]>
Yes, this is good point! |
This was referenced Mar 13, 2025
mashhurs
added a commit
to mashhurs/logstash-input-elasticsearch
that referenced
this pull request
Mar 17, 2025
…-transport-client Adds elastic-transport client support. (cherry picked from commit b920701)
mashhurs
added a commit
to mashhurs/logstash-input-elasticsearch
that referenced
this pull request
Mar 17, 2025
mashhurs
added a commit
to mashhurs/logstash-input-elasticsearch
that referenced
this pull request
Mar 17, 2025
mashhurs
added a commit
that referenced
this pull request
Mar 17, 2025
Fix the unit test failures caused by #223
mashhurs
added a commit
that referenced
this pull request
Mar 17, 2025
Merge pull request #223 from mashhurs/support-elastic-transport-client
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds elastic-transport client support where opens LS-core a way to start using newer ES ruby client.
FYI: failed Test plugin docs CI is not related to this change.