Skip to content

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Jun 16, 2021

With ES having a single distribution we can greatly simplify the implementation and testing. This is possible because this plugin will behave the same on either default or oss Logstash.

@jsvd jsvd changed the title draft pr simplify plugin by removing distribution specific code Jun 16, 2021
@jsvd jsvd marked this pull request as ready for review June 16, 2021 16:34
@elasticsearch-bot elasticsearch-bot self-assigned this Jun 18, 2021
@andsel andsel self-requested a review June 18, 2021 09:49
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit d17d837 into logstash-plugins:master Jun 18, 2021
@jsvd jsvd deleted the remove_oss_specific_code branch June 18, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants