remove 1x, 2x and 5x specific code #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
force-pushed
the
remove_1x_2x_5x_code
branch
from
eba9a53 to
cb97ded
Compare
kares
reviewed
Jun 21, 2021
Contributor
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
LGTM, this enabled us to simplify the code - considerably.
One minor suggestion about removing a potential dead method.
jsvd
force-pushed
the
remove_1x_2x_5x_code
branch
from
cb97ded to
b2d3f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change depends on #1020