Fix for crashes related to overrides #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s fixed
Nightscout override segments are now sanitised before they hit the graph layer, so they never overlap and are never shorter than 5 minutes.
Why it crashed before
I trimmed each segment while iterating newest → oldest.
That meant I sometimes pushed the segment’s end earlier than its start, giving negative (or zero-length) durations.
The graph code asserts that duration > 0, so the app crashed as soon as one of those bad dots was drawn.
How it’s solved
1. Sort overrides oldest → newest first.
2. For each segment, cap its end at (nextStart − 5 min).
3. Skip any segment that ends up < 5 min long.
The result is a clean, strictly sequential timeline, so the graph renders without blowing up.