Skip to content

Conversation

@bjorkert
Copy link
Contributor

This PR fixes a regression introduced in #400, where indefinite overrides created by Loop were incorrectly displayed as 5-minute events until they ended. Once terminated, they were updated with the correct duration and rendered properly.

With this fix, indefinite overrides are now shown correctly from the start.

@bjorkert bjorkert requested a review from marionbarker May 23, 2025 17:30
@marionbarker
Copy link
Collaborator

Test

Confirm the problem

Configure a test phone to upload to NS and be followed using LoopFollow 2.5.0

  • Issue an indefinite override on the Loop phone
  • Wait at least one loop cycle for NS to update
    • Observe that the indefinite override shows up as 5 minutes extent while running
  • Cancel the override on the Loop phone
    • Observe that after canceling the override, the extent shown is the actual time it was engaged

Confirm this PR works as expected

Configure a test phone to upload to NS and be followed using this branch

  • Issue an indefinite override on the Loop phone
  • Wait at least one loop cycle for NS to update
    • Observe that the indefinite override shows up indefinite - watch for a few more cycles
  • Cancel the override on the Loop phone after 42 minutes
    • Observe that after canceling the override, the extent shown is the actual time it was engaged

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from code review and test

@marionbarker marionbarker merged commit 7ea67fa into dev May 29, 2025
@marionbarker marionbarker deleted the loop-indefinite-override-fix branch May 29, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants