Skip to content

CYMK to RGB Conversion won't work when Magento Compiler is on #16

@jasperthedummy

Description

@jasperthedummy

Pull request #14 (@rbrown) introduced support for CYMK images by converting them to RGB so that an image resize will not cause an image to become inverted in color. However, it doesn't work for sites using the Magento compiler, because the use of __DIR__ magic constant will point to [magento_root]/includes/src, instead of where the ICC profiles currently live [magento_root]/app/code/community/Varien/Image/Adapter/. The resulting resized image will still be inverted in color.

Suggestion to put the ICC files in [magento_root]/lib/FireGento/PerfectWatermarks/.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions