Convert CYMK images to RGB #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our images are in CMYK, when they're resized onto a different shape canvas, the canvas colour inverts when the colorspace is changed. This patch tries to convert the CMYK images to sRGB before compositing them. The conversion code was taken from http://php.net/manual/en/imagick.setimagecolorspace.php
|
I will have look and thanks for the PR. |
datenbrille
added a commit
that referenced
this pull request
May 18, 2015
Convert CYMK images to RGB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our images are in CMYK, when they're resized onto a different shape
canvas, the canvas colour inverts when the colorspace is changed. This patch
tries to convert the CMYK images to sRGB before compositing them. The conversion
code was taken from http://php.net/manual/en/imagick.setimagecolorspace.php
I couldn’t see a better way to do this (short of converting all our existing images, and any new ones it RGB first. I wasn’t really sure if dropping the profiles in the PHP dir was the best place either, but couldn’t see another place to put it.