build fails on Julia 1.0 with "is_windows not defined"

[adamryczkowski]

Pkg.build("TensorFlow")
  Building Arpack ──────────→ `~/.julia/packages/Arpack/Btbe4/deps/build.log`
  Building SpecialFunctions → `~/.julia/packages/SpecialFunctions/KvXoO/deps/build.log`
  Building Rmath ───────────→ `~/.julia/packages/Rmath/Py9gH/deps/build.log`
  Building LibCURL ─────────→ `~/.julia/packages/LibCURL/p0LUA/deps/build.log`
  Building WinRPM ──────────→ `~/.julia/packages/WinRPM/rDDZz/deps/build.log`
  Building Homebrew ────────→ `~/.julia/packages/Homebrew/l8kUw/deps/build.log`
  Building CMakeWrapper ────→ `~/.julia/packages/CMakeWrapper/R7ZgO/deps/build.log`
  Building Blosc ───────────→ `~/.julia/packages/Blosc/lzFr0/deps/build.log`
  Building HDF5 ────────────→ `~/.julia/packages/HDF5/PegIy/deps/build.log`
  Building Conda ───────────→ `~/.julia/packages/Conda/m7vem/deps/build.log`
  Building PyCall ──────────→ `~/.julia/packages/PyCall/fiJ3o/deps/build.log`
  Building TensorFlow ──────→ `~/.julia/packages/TensorFlow/TizFt/deps/build.log`
┌ Error: Error building `TensorFlow`: 
│ WARNING: could not import Base.start into PyCall
│ WARNING: could not import Base.done into PyCall
│ WARNING: could not import Base.next into PyCall
│ ERROR: LoadError: UndefVarError: is_windows not defined
│ Stacktrace:
│  [1] top-level scope at none:0
│  [2] include at ./boot.jl:317 [inlined]
│  [3] include_relative(::Module, ::String) at ./loading.jl:1038
│  [4] include(::Module, ::String) at ./sysimg.jl:29
│  [5] include(::String) at ./client.jl:388
│  [6] top-level scope at none:0
│ in expression starting at /home/adam/.julia/packages/TensorFlow/TizFt/deps/build.jl:13

The error seems very similar to the following error I reported to the LibCURL: JuliaWeb/LibCURL.jl#44 . They have pushed the patch which might help you fixing the problem in the TensorFlow too.

[oxinabox]

Hmmm, @femtocleaner[bot] should have fixed that.
@malmaud Did this get femtocleaned yet?

[adamryczkowski]

It appears the problem with the 1.0.0 is much deeper.

I spent half of the sunday fixing various deprecation bugs (with obvious solutions) until I stomped on the following error:

julia> import TensorFlow
[ Info: Precompiling TensorFlow [1d978283-2c37-5f34-9a8e-e9c0ece82495]
┌ Warning: Loading a new version of TensorFlow.jl for the first time. This initial load can take around 5 minutes as code is precompiled; subsequent usage will only take a few seconds.
└ @ TensorFlow ~/.julia/packages/TensorFlow/qrmc9/src/TensorFlow.jl:6
ERROR: LoadError: UndefVarError: broadcast_c not defined
Stacktrace:
 [1] include at ./boot.jl:317 [inlined]
 [2] include_relative(::Module, ::String) at ./loading.jl:1038
 [3] include(::Module, ::String) at ./sysimg.jl:29
 [4] top-level scope at none:2
 [5] eval at ./boot.jl:319 [inlined]
 [6] eval(::Expr) at ./client.jl:389
 [7] top-level scope at ./none:3
in expression starting at /home/adam/.julia/packages/TakingBroadcastSeriously/WQSQT/src/TakingBroadcastSeriously.jl:3
ERROR: LoadError: LoadError: Failed to precompile TakingBroadcastSeriously [fa778a35-eff5-5ebc-91c5-11ea73160f07] to /home/adam/.julia/compiled/v1.1/TakingBroadcastSeriously/RVPKc.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] macro expansion at ./logging.jl:313 [inlined]
 [3] compilecache(::Base.PkgId, ::String) at ./loading.jl:1184
 [4] _require(::Base.PkgId) at ./logging.jl:311
 [5] require(::Base.PkgId) at ./loading.jl:852
 [6] require(::Module, ::Symbol) at ./logging.jl:311
 [7] include at ./boot.jl:317 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1038
 [9] include at ./sysimg.jl:29 [inlined]
 [10] include(::String) at /home/adam/.julia/packages/TensorFlow/qrmc9/src/TensorFlow.jl:2
 [11] top-level scope at none:0
 [12] include at ./boot.jl:317 [inlined]
 [13] include_relative(::Module, ::String) at ./loading.jl:1038
 [14] include(::Module, ::String) at ./sysimg.jl:29
 [15] top-level scope at none:2
 [16] eval at ./boot.jl:319 [inlined]
 [17] eval(::Expr) at ./client.jl:389
 [18] top-level scope at ./none:3
in expression starting at /home/adam/.julia/packages/TensorFlow/qrmc9/src/ops.jl:5
in expression starting at /home/adam/.julia/packages/TensorFlow/qrmc9/src/TensorFlow.jl:189
ERROR: Failed to precompile TensorFlow [1d978283-2c37-5f34-9a8e-e9c0ece82495] to /home/adam/.julia/compiled/v1.1/TensorFlow/IhIhf.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] macro expansion at ./logging.jl:313 [inlined]
 [3] compilecache(::Base.PkgId, ::String) at ./loading.jl:1184
 [4] macro expansion at ./logging.jl:311 [inlined]
 [5] _require(::Base.PkgId) at ./loading.jl:941
 [6] require(::Base.PkgId) at ./loading.jl:852
 [7] require(::Module, ::Symbol) at ./logging.jl:311

It seems that TakingBroadcastSeriously is no longer needed, because with Julia 0.7 we can overload broadcasting directly (JuliaAttic/TakingBroadcastSeriously.jl#8). I feel fixing it is still out of my league, so I leave it there for the time being.

For everyone interested I attach my work in progress #419. When this problem is resolved I will gladly finish the migration.

[malmaud]

Closed by #419