Update pnpm to version 8 #21118
Update pnpm to version 8 #21118
Conversation
github-actions
bot
added
dependencies
github-actions
bot
added
area: build
There was a problem hiding this comment.
Skimmed two of the lockfiles. The things I saw seemed reasonable; I don't think a line-by-line review is reasonable in this case.
Any reason why we only converted those two in tools/? benchmark, changelog-generator-wrwapper, markdown-magic, and test-tools are also on pnpm.
| lockfileVersion: '6.0' | ||
|
|
||
| settings: | ||
| autoInstallPeers: true |
There was a problem hiding this comment.
This caught my eye... not sure what does it mean in the lockfile, but we don't currently auto-install peer deps, right?
There was a problem hiding this comment.
Interesting. I'll look into that. I'm guessing its a new setting in pnpm 8 with that as the default.
There was a problem hiding this comment.
From what I can tell, this matches how npm's behavior, and can be controlled via the npmrc file which we do have and has some related settings in it. I think this effects commands like pnpm i foo to add new dependencies (matching what npm i foo` would do), and we can reconfigure it from the default in our .npmrc file later if we do not like this behavior.
Thats a bug. When searching for package.json files to update, I had a comma at the end of my search thus skipping packages where "packageManager": was the last key. I'll fix it |
I also missed several packages using different version of pnpm, and a couple that didn't have an enforced version. Now there are no longer any hits for |
| submodules: false | ||
| - uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598 # ratchet:pnpm/action-setup@v2 | ||
| with: | ||
| version: "^7" |
There was a problem hiding this comment.
This is required if the package.json does not specify a version , and optional if it does. Since a version is now provided in the package.json, this can be removed, see https://github.com/pnpm/action-setup?tab=readme-ov-file#version for details.
3 participants
Description
Update pnpm to version 8. That means lock-file format version 6.
This relies on microsoft/component-detection#1110 which seems to be deployed and working now.
This gets us onto a supported version of pnpm according to https://github.com/pnpm/pnpm/security.
Reviewer Guidance
The review process is outlined on this wiki page.