-
Couldn't load subscription status.
- Fork 107
Add pnpm v6 support as an experimental detector #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
=======================================
- Coverage 75.7% 75.6% -0.1%
=======================================
Files 239 245 +6
Lines 10822 10958 +136
Branches 1086 1100 +14
=======================================
+ Hits 8193 8295 +102
- Misses 2317 2343 +26
- Partials 312 320 +8 ☔ View full report in Codecov by Sentry. |
src/Microsoft.ComponentDetection.Detectors/pnpm/Contracts/PnpmHasDependenciesV6.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/Pnpm6ComponentDetector.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/Pnpm6ComponentDetector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/Pnpm6ComponentDetector.cs
Outdated
Show resolved
Hide resolved
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
## Description Update pnpm to version 8. That means lock-file format version 6. This relies on microsoft/component-detection#1110 which seems to be deployed and working now. This gets us onto a supported version of pnpm according to https://github.com/pnpm/pnpm/security.
After discussing with @CraigMacomber on #1028 we decided to take an experimental approach during rollout of PNPM lockfile v6 scanning. This PR is a modified version of the fork created with the experimental detector setup added along with some minor changes.
Original PR description: