Skip to content

Conversation

pauld-msft
Copy link
Member

Pnpm6 has gone through a week or so of experimentation after being introduced with #1110 and has been validated to work as expected.

This pull request:

  • removes the experiment
  • merges the pnpm6 changes into pnpm detector, using the suggested format from this comment
  • increments Pnpm detector version from 5 -> 6

@pauld-msft pauld-msft requested a review from a team as a code owner May 31, 2024 19:55
@pauld-msft pauld-msft requested a review from FernandoRojo May 31, 2024 19:55
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 94.16667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.3%. Comparing base (9c3b0d5) to head (bfd9c50).

Files Patch % Lines
...ion.Detectors/pnpm/PnpmComponentDetectorFactory.cs 93.4% 4 Missing and 1 partial ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm5Detector.cs 94.1% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1145     +/-   ##
=======================================
+ Coverage   76.1%   76.3%   +0.1%     
=======================================
  Files        255     255             
  Lines      11306   11298      -8     
  Branches    1135    1134      -1     
=======================================
+ Hits        8614    8622      +8     
+ Misses      2357    2344     -13     
+ Partials     335     332      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 31, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Contributor

@cobya cobya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@cobya cobya added version:minor type:feature Feature (new functionality) detector:pnpm The pnpm detector labels Jun 3, 2024
@pauld-msft pauld-msft merged commit 393db47 into main Jun 3, 2024
@pauld-msft pauld-msft deleted the pauldorsch/merge-pnpm6-with-existing-pnpm branch June 3, 2024 17:02
cobya added a commit that referenced this pull request Jun 6, 2024
* Add CodeQL debug (#1142)

* Increase Python cache window (#1144)

* Increase Python cache window

* Update pip.md

* Update IPyPiClient.cs

* Merged pnpm6 experiment into pnpm detector (#1145)

* merged pnpm6 into pnpm detector

* bump version and make the factory method private

* name of type

* improved logging

* added telemetry record for pnpm, and other minor updates to methods for conciseness

* standardize the invalid version telemetry object

* removed invalid version file

* Use .NET 8

* Fix new analyzer errors

* Update integration tests

* Update minimatch

* Pauldorsch/remove pip report throw (#1151)

* remove throw for pip report so all pip files will be scanned

* fix tests

* Update NormalizePath to be more robust (#1152)

* fix the requested_extras parsing for pip report (#1154)

* Simple sanitization in strings used in CLI before logging (#1155)

* Bump github/codeql-action from 3.25.6 to 3.25.8 (#1153)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@9fdb3e4...2e230e8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update dependency minver to v5 (#1140)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update nuget monorepo to v6.10.0 (#1138)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency yamldotnet to v15 (#982)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Gradle parsing to reduce calls to IsDevDependencyByLockfile (#1156)

* Update renovate.json configuration (#1157)

Update renovate.json configuration to limit open branches and add weekly lock file maintenance.

* Specifiy smoke test config

* Set restore target

* Use new NuGet smoke test repo

* Update NuGet test

* Add workload step

* Update test repo

* Add Python install

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Paul Dorsch <[email protected]>
Co-authored-by: Greg Villicana <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detector:pnpm The pnpm detector type:feature Feature (new functionality) version:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants