-
Notifications
You must be signed in to change notification settings - Fork 106
Merged pnpm6 experiment into pnpm detector #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
+ Coverage 76.1% 76.3% +0.1%
=======================================
Files 255 255
Lines 11306 11298 -8
Branches 1135 1134 -1
=======================================
+ Hits 8614 8622 +8
+ Misses 2357 2344 -13
+ Partials 335 332 -3 ☔ View full report in Codecov by Sentry. |
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
…ithub.com/microsoft/component-detection into pauldorsch/merge-pnpm6-with-existing-pnpm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
src/Microsoft.ComponentDetection.Detectors/pnpm/PnpmComponentDetectorFactory.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/PnpmComponentDetectorFactory.cs
Show resolved
Hide resolved
* Add CodeQL debug (#1142) * Increase Python cache window (#1144) * Increase Python cache window * Update pip.md * Update IPyPiClient.cs * Merged pnpm6 experiment into pnpm detector (#1145) * merged pnpm6 into pnpm detector * bump version and make the factory method private * name of type * improved logging * added telemetry record for pnpm, and other minor updates to methods for conciseness * standardize the invalid version telemetry object * removed invalid version file * Use .NET 8 * Fix new analyzer errors * Update integration tests * Update minimatch * Pauldorsch/remove pip report throw (#1151) * remove throw for pip report so all pip files will be scanned * fix tests * Update NormalizePath to be more robust (#1152) * fix the requested_extras parsing for pip report (#1154) * Simple sanitization in strings used in CLI before logging (#1155) * Bump github/codeql-action from 3.25.6 to 3.25.8 (#1153) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@9fdb3e4...2e230e8) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update dependency minver to v5 (#1140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update nuget monorepo to v6.10.0 (#1138) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency yamldotnet to v15 (#982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Gradle parsing to reduce calls to IsDevDependencyByLockfile (#1156) * Update renovate.json configuration (#1157) Update renovate.json configuration to limit open branches and add weekly lock file maintenance. * Specifiy smoke test config * Set restore target * Use new NuGet smoke test repo * Update NuGet test * Add workload step * Update test repo * Add Python install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Greg Villicana <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Pnpm6
has gone through a week or so of experimentation after being introduced with #1110 and has been validated to work as expected.This pull request: