Skip to content

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Jun 4, 2024

When running the Pip detection for setup.py files, there were extra unicode characters being added to the normalized path strings. This will fix that issue by normalizing to / which is valid on both Unix and Windows.

@cobya cobya requested a review from a team as a code owner June 4, 2024 22:04
@cobya cobya requested a review from daniel-akili June 4, 2024 22:04
@cobya cobya added version:patch type:bug Bug fix of existing functionality detector:pip The pip detector labels Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (393db47) to head (8ca3637).
Report is 1 commits behind head on main.

Files Patch % Lines
...ft.ComponentDetection.Common/PathUtilityService.cs 50.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1152   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        255     255           
  Lines      11298   11338   +40     
  Branches    1134    1146   +12     
=====================================
+ Hits        8622    8661   +39     
- Misses      2344    2345    +1     
  Partials     332     332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya cobya enabled auto-merge (squash) June 4, 2024 22:06
@cobya cobya merged commit 9f1e5a9 into main Jun 4, 2024
@cobya cobya deleted the cobya/Path branch June 4, 2024 22:10
Copy link

github-actions bot commented Jun 4, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

cobya added a commit that referenced this pull request Jun 6, 2024
* Add CodeQL debug (#1142)

* Increase Python cache window (#1144)

* Increase Python cache window

* Update pip.md

* Update IPyPiClient.cs

* Merged pnpm6 experiment into pnpm detector (#1145)

* merged pnpm6 into pnpm detector

* bump version and make the factory method private

* name of type

* improved logging

* added telemetry record for pnpm, and other minor updates to methods for conciseness

* standardize the invalid version telemetry object

* removed invalid version file

* Use .NET 8

* Fix new analyzer errors

* Update integration tests

* Update minimatch

* Pauldorsch/remove pip report throw (#1151)

* remove throw for pip report so all pip files will be scanned

* fix tests

* Update NormalizePath to be more robust (#1152)

* fix the requested_extras parsing for pip report (#1154)

* Simple sanitization in strings used in CLI before logging (#1155)

* Bump github/codeql-action from 3.25.6 to 3.25.8 (#1153)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@9fdb3e4...2e230e8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update dependency minver to v5 (#1140)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update nuget monorepo to v6.10.0 (#1138)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency yamldotnet to v15 (#982)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Gradle parsing to reduce calls to IsDevDependencyByLockfile (#1156)

* Update renovate.json configuration (#1157)

Update renovate.json configuration to limit open branches and add weekly lock file maintenance.

* Specifiy smoke test config

* Set restore target

* Use new NuGet smoke test repo

* Update NuGet test

* Add workload step

* Update test repo

* Add Python install

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Paul Dorsch <[email protected]>
Co-authored-by: Greg Villicana <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:pip The pip detector type:bug Bug fix of existing functionality version:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants