Skip to content

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Jun 4, 2024

The .NET 8 release was recently made available and we are updating component-detection to the new version. See #771 for more information.

Since these are breaking changes, they will be merged into the cobya/v5 major release tracking branch in conjuction with #1135.

cobya and others added 5 commits May 29, 2024 08:58
* Increase Python cache window

* Update pip.md

* Update IPyPiClient.cs
* merged pnpm6 into pnpm detector

* bump version and make the factory method private

* name of type

* improved logging

* added telemetry record for pnpm, and other minor updates to methods for conciseness

* standardize the invalid version telemetry object

* removed invalid version file
@cobya cobya added version:major type:feature Feature (new functionality) dependencies Pull requests that update a dependency file breaking change Breaking change, requires major version bump .NET Pull requests that update .net code labels Jun 4, 2024
@cobya cobya requested a review from a team as a code owner June 4, 2024 16:14
@cobya cobya requested a review from chsalgado June 4, 2024 16:14
Copy link

github-actions bot commented Jun 4, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@cobya cobya changed the base branch from main to cobya/v5 June 4, 2024 16:22
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 88.79310% with 52 lines in your changes missing coverage. Please review.

Project coverage is 76.7%. Comparing base (e52ef78) to head (1019bf3).

Files Patch % Lines
...ft.ComponentDetection.Common/PathUtilityService.cs 40.0% 2 Missing and 4 partials ⚠️
...ComponentDetection.Detectors/pip/PythonResolver.cs 0.0% 1 Missing and 5 partials ⚠️
...ion.Detectors/pnpm/PnpmComponentDetectorFactory.cs 93.4% 4 Missing and 1 partial ⚠️
...entDetection.Detectors/rust/CargoDependencyData.cs 0.0% 4 Missing ⚠️
...onentDetection.Common/Utilities/StringUtilities.cs 72.7% 3 Missing ⚠️
...Detection.Detectors/npm/NpmLockfileDetectorBase.cs 72.7% 3 Missing ⚠️
...entDetection.Detectors/pip/SimplePythonResolver.cs 62.5% 0 Missing and 3 partials ⚠️
...ntDetection.Common/CommandLineInvocationService.cs 60.0% 1 Missing and 1 partial ⚠️
...ection.Common/DependencyGraph/ComponentRecorder.cs 66.6% 2 Missing ⚠️
...ion.Detectors/go/GoComponentWithReplaceDetector.cs 83.3% 0 Missing and 2 partials ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           cobya/v5   #1150     +/-   ##
==========================================
+ Coverage      76.5%   76.7%   +0.1%     
==========================================
  Files           256     257      +1     
  Lines         11712   11672     -40     
  Branches       1208    1199      -9     
==========================================
- Hits           8970    8961      -9     
+ Misses         2386    2359     -27     
+ Partials        356     352      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya cobya linked an issue Jun 4, 2024 that may be closed by this pull request
cobya and others added 12 commits June 4, 2024 14:02
* remove throw for pip report so all pip files will be scanned

* fix tests
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@9fdb3e4...2e230e8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Update renovate.json configuration to limit open branches and add weekly lock file maintenance.
@cobya cobya merged commit 6d2e344 into cobya/v5 Jun 6, 2024
@cobya cobya deleted the cobya/Net8 branch June 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change, requires major version bump dependencies Pull requests that update a dependency file .NET Pull requests that update .net code type:feature Feature (new functionality) version:major
Development

Successfully merging this pull request may close these issues.

Switch to .NET 8
4 participants