Pauldorsch/remove pip report throw #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
=====================================
Coverage 76.3% 76.3%
=====================================
Files 255 255
Lines 11298 11298
Branches 1134 1134
=====================================
Hits 8622 8622
Misses 2344 2344
Partials 332 332 ☔ View full report in Codecov by Sentry. |
pauld-msft
added
detector:pip
cobya
added
version:patch
type:bug
cobya
approved these changes
Jun 4, 2024
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
cobya
added a commit
that referenced
this pull request
Jun 6, 2024
* Add CodeQL debug (#1142) * Increase Python cache window (#1144) * Increase Python cache window * Update pip.md * Update IPyPiClient.cs * Merged pnpm6 experiment into pnpm detector (#1145) * merged pnpm6 into pnpm detector * bump version and make the factory method private * name of type * improved logging * added telemetry record for pnpm, and other minor updates to methods for conciseness * standardize the invalid version telemetry object * removed invalid version file * Use .NET 8 * Fix new analyzer errors * Update integration tests * Update minimatch * Pauldorsch/remove pip report throw (#1151) * remove throw for pip report so all pip files will be scanned * fix tests * Update NormalizePath to be more robust (#1152) * fix the requested_extras parsing for pip report (#1154) * Simple sanitization in strings used in CLI before logging (#1155) * Bump github/codeql-action from 3.25.6 to 3.25.8 (#1153) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@9fdb3e4...2e230e8) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update dependency minver to v5 (#1140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update nuget monorepo to v6.10.0 (#1138) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency yamldotnet to v15 (#982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Gradle parsing to reduce calls to IsDevDependencyByLockfile (#1156) * Update renovate.json configuration (#1157) Update renovate.json configuration to limit open branches and add weekly lock file maintenance. * Specifiy smoke test config * Set restore target * Use new NuGet smoke test repo * Update NuGet test * Add workload step * Update test repo * Add Python install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Greg Villicana <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipReport throws when file detector fails, which causes other files to not have the pipreport run on them. We want to just log / output telemetry instead of throwing.