Fixes issue where arguments aren't passed to helm uninstall commands #21295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaustin700
changed the title
tomaustin700
changed the title
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21295 in repo microsoft/azure-pipelines-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes the issue where helm arguments aren't passed if a helm uninstall command is used. See #21047
Task Name
HelmDeploy@1
Description
Added the missing
.addArgumentsto helm uninstall to allow passing of arguments if a helm uninstall command is used.Risk Assessment (Low / Medium / High)
Low - just extending an existing command to pass arguments like other helm commands do
Change Behind Feature Flag (Yes / No)
No
Tech Design / Approach
Other helm commands already implement this logic (see helm upgrade for example) so just copies their implementation.
Documentation Changes Required (Yes/No)
No - docs already state this functionality is supported
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)
Yes
Checklist